[BUG]: Fixed Vertical & Horizontal Bar visualization issues #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Codecov Report
@@ Coverage Diff @@
## main #1156 +/- ##
=========================================
Coverage 53.70% 53.71%
Complexity 291 291
=========================================
Files 279 279
Lines 9490 9494 +4
Branches 2244 2248 +4
=========================================
+ Hits 5097 5100 +3
Misses 4223 4223
- Partials 170 171 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Koustubh5585
changed the title
Koustubh5585
changed the title
mengweieric
previously approved these changes
Oct 20, 2022
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
ps48
reviewed
Oct 20, 2022
Comment on lines
81
to
87
| // Gauge = 'gauge', | ||
| // Histogram = 'histogram', | ||
| // TreeMap = 'tree_map', | ||
| // Scatter = 'scatter', | ||
| // LogsView = 'logs_view', | ||
| // Metrics = 'metrics', | ||
| // TableView = 'data_table', |
There was a problem hiding this comment.
can we remove comments if not needed?
There was a problem hiding this comment.
+1 yes let's remove these rather than commented out.
There was a problem hiding this comment.
Hi @ps48 @mengweieric commented as this is not a permanent removing of the feature, we may uncomment it in future. Anyways I will remove it.
There was a problem hiding this comment.
we can always add back without commenting or uncommenting.
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
mengweieric
approved these changes
Oct 21, 2022
joshuali925
approved these changes
Oct 21, 2022
pjfitzgibbons
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed visualization issues of vertical and horizontal bar chart
Issues Resolved
#1153
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.