-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Update deprecated openAI mode in integration test and fix flaky tests… #1858
Merged
ylwu-amzn
merged 1 commit into
opensearch-project:2.x
from
Hailong-am:backport/backport-1846-to-2.x
Jan 12, 2024
Merged
[Backport 2.x] Update deprecated openAI mode in integration test and fix flaky tests… #1858
ylwu-amzn
merged 1 commit into
opensearch-project:2.x
from
Hailong-am:backport/backport-1846-to-2.x
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opensearch-project#1846) * Fix flaky test Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove unused import Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace deprecated openAI model in test Signed-off-by: Hailong Cui <ihailong@amazon.com> * ignore testOpenAIEditsModel as it's deprecated Signed-off-by: Hailong Cui <ihailong@amazon.com> * typo fix Signed-off-by: Hailong Cui <ihailong@amazon.com> * update admin password Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix getConversations when index not exists Signed-off-by: Hailong Cui <ihailong@amazon.com> * update blueprint doc Signed-off-by: Hailong Cui <ihailong@amazon.com> * update edit model to gpt-4 Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove hardcode password Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace deprecating set-output Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 6584529)
Hailong-am
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
January 12, 2024 05:34
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 05:34 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 05:34 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 05:34 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 05:34 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 05:34 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 05:34 — with
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1858 +/- ##
============================================
+ Coverage 82.46% 82.60% +0.14%
- Complexity 5314 5388 +74
============================================
Files 510 521 +11
Lines 21446 21705 +259
Branches 2202 2211 +9
============================================
+ Hits 17685 17930 +245
- Misses 2867 2876 +9
- Partials 894 899 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 05:56 — with
GitHub Actions
Failure
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 05:56 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 05:56 — with
GitHub Actions
Failure
ylwu-amzn
approved these changes
Jan 12, 2024
rbhavna
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6584529 from #1846