Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Update deprecated openAI mode in integration test and fix flaky tests… #1858

Merged

Conversation

Hailong-am
Copy link
Contributor

Backport 6584529 from #1846

…opensearch-project#1846)

* Fix flaky test

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove unused import

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* replace deprecated openAI model in test

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* ignore testOpenAIEditsModel as it's deprecated

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* typo fix

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update admin password

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* fix getConversations when index not exists

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update blueprint doc

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* update edit model to gpt-4

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove hardcode password

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* replace deprecating set-output

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 6584529)
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (7f72d74) 82.46% compared to head (4d0ecfb) 82.60%.
Report is 4 commits behind head on 2.x.

Files Patch % Lines
...opensearch/ml/engine/indices/MLIndicesHandler.java 33.33% 3 Missing and 1 partial ⚠️
...rch/ml/common/transport/tools/MLGetToolAction.java 0.00% 3 Missing ⚠️
...h/ml/common/transport/tools/MLListToolsAction.java 0.00% 3 Missing ⚠️
...ch/ml/common/transport/tools/MLToolGetRequest.java 88.00% 1 Missing and 2 partials ⚠️
.../ml/common/transport/tools/MLToolsListRequest.java 89.47% 1 Missing and 1 partial ⚠️
...java/org/opensearch/ml/engine/tools/AgentTool.java 0.00% 2 Missing ⚠️
...a/org/opensearch/ml/engine/tools/CatIndexTool.java 0.00% 2 Missing ⚠️
...va/org/opensearch/ml/engine/tools/MLModelTool.java 0.00% 2 Missing ⚠️
...in/java/org/opensearch/ml/common/ToolMetadata.java 98.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1858      +/-   ##
============================================
+ Coverage     82.46%   82.60%   +0.14%     
- Complexity     5314     5388      +74     
============================================
  Files           510      521      +11     
  Lines         21446    21705     +259     
  Branches       2202     2211       +9     
============================================
+ Hits          17685    17930     +245     
- Misses         2867     2876       +9     
- Partials        894      899       +5     
Flag Coverage Δ
ml-commons 82.60% <91.66%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ylwu-amzn ylwu-amzn merged commit afb5125 into opensearch-project:2.x Jan 12, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants