-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated openAI mode in integration test and fix flaky tests #1846
Merged
ylwu-amzn
merged 11 commits into
opensearch-project:main
from
Hailong-am:flaky_test_fix
Jan 12, 2024
Merged
Update deprecated openAI mode in integration test and fix flaky tests #1846
ylwu-amzn
merged 11 commits into
opensearch-project:main
from
Hailong-am:flaky_test_fix
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
January 9, 2024 09:03
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 09:03 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 09:03 — with
GitHub Actions
Failure
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 09:03 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 09:04 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 09:04 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 09:04 — with
GitHub Actions
Failure
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 15:48 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 15:48 — with
GitHub Actions
Failure
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 15:48 — with
GitHub Actions
Failure
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 15:48 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 15:48 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 15:48 — with
GitHub Actions
Failure
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 16:20 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 16:20 — with
GitHub Actions
Failure
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 16:20 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 9, 2024 16:20 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 11, 2024 16:19 — with
GitHub Actions
Failure
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 11, 2024 16:19 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 01:12 — with
GitHub Actions
Failure
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 01:12 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 01:12 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 01:12 — with
GitHub Actions
Error
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 01:12 — with
GitHub Actions
Inactive
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 01:12 — with
GitHub Actions
Error
Zhangxunmt
previously approved these changes
Jan 12, 2024
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 02:41 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 02:41 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 02:41 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 02:41 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 02:41 — with
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
January 12, 2024 02:41 — with
GitHub Actions
Inactive
dhrubo-os
approved these changes
Jan 12, 2024
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 03:03 — with
GitHub Actions
Failure
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 03:03 — with
GitHub Actions
Error
Hailong-am
had a problem deploying
to
ml-commons-cicd-env
January 12, 2024 03:03 — with
GitHub Actions
Failure
ylwu-amzn
approved these changes
Jan 12, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1846-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6584529ebc4554d25d8ba664913b2fab7e644c0e
# Push it to GitHub
git push --set-upstream origin backport/backport-1846-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Hailong-am
added a commit
to Hailong-am/ml-commons
that referenced
this pull request
Jan 12, 2024
…opensearch-project#1846) * Fix flaky test Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove unused import Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace deprecated openAI model in test Signed-off-by: Hailong Cui <ihailong@amazon.com> * ignore testOpenAIEditsModel as it's deprecated Signed-off-by: Hailong Cui <ihailong@amazon.com> * typo fix Signed-off-by: Hailong Cui <ihailong@amazon.com> * update admin password Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix getConversations when index not exists Signed-off-by: Hailong Cui <ihailong@amazon.com> * update blueprint doc Signed-off-by: Hailong Cui <ihailong@amazon.com> * update edit model to gpt-4 Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove hardcode password Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace deprecating set-output Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 6584529)
ylwu-amzn
pushed a commit
that referenced
this pull request
Jan 12, 2024
…#1846) (#1858) * Fix flaky test Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove unused import Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace deprecated openAI model in test Signed-off-by: Hailong Cui <ihailong@amazon.com> * ignore testOpenAIEditsModel as it's deprecated Signed-off-by: Hailong Cui <ihailong@amazon.com> * typo fix Signed-off-by: Hailong Cui <ihailong@amazon.com> * update admin password Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix getConversations when index not exists Signed-off-by: Hailong Cui <ihailong@amazon.com> * update blueprint doc Signed-off-by: Hailong Cui <ihailong@amazon.com> * update edit model to gpt-4 Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove hardcode password Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace deprecating set-output Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 6584529)
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…opensearch-project#1846) * Fix flaky test Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove unused import Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace deprecated openAI model in test Signed-off-by: Hailong Cui <ihailong@amazon.com> * ignore testOpenAIEditsModel as it's deprecated Signed-off-by: Hailong Cui <ihailong@amazon.com> * typo fix Signed-off-by: Hailong Cui <ihailong@amazon.com> * update admin password Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix getConversations when index not exists Signed-off-by: Hailong Cui <ihailong@amazon.com> * update blueprint doc Signed-off-by: Hailong Cui <ihailong@amazon.com> * update edit model to gpt-4 Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove hardcode password Signed-off-by: Hailong Cui <ihailong@amazon.com> * replace deprecating set-output Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes for below items
Issues Resolved
#1848 and #1849
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.