Add index settings to super constructor call for knn codec service #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
junqiu-lei
as code owners
navneet1v
approved these changes
Jul 11, 2023
junqiu-lei
approved these changes
Jul 11, 2023
martin-gaievski
merged commit a249f21
into
opensearch-project:main
22 of 52 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit a249f21)
martin-gaievski
added a commit
that referenced
this pull request
Jul 11, 2023
naveentatikonda
pushed a commit
to naveentatikonda/k-NN
that referenced
this pull request
Jul 11, 2023
…earch-project#962) Signed-off-by: Martin Gaievski <gaievski@amazon.com>
naveentatikonda
pushed a commit
to naveentatikonda/k-NN
that referenced
this pull request
Jul 11, 2023
…earch-project#962) Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consume core change opensearch-project/OpenSearch#8312 and fix corresponding compilation errors.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.