Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport-2.x] Enabled the efficient filtering support for Faiss Engine. #960

Merged
merged 3 commits into from
Jul 10, 2023

Fixing unit test for Faiss due to faiss upgrade. (#951)

50f15b3
Select commit
Loading
Failed to load commit list.
Merged

[Backport-2.x] Enabled the efficient filtering support for Faiss Engine. #960

Fixing unit test for Faiss due to faiss upgrade. (#951)
50f15b3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 10, 2023 in 0s

85.05% (target 70.00%)

View this Pull Request on Codecov

85.05% (target 70.00%)

Details

Codecov Report

Merging #960 (50f15b3) into 2.x (f11f1f1) will decrease coverage by 0.09%.
The diff coverage is 84.82%.

@@             Coverage Diff              @@
##                2.x     #960      +/-   ##
============================================
- Coverage     85.13%   85.05%   -0.09%     
- Complexity     1088     1116      +28     
============================================
  Files           152      152              
  Lines          4414     4530     +116     
  Branches        392      409      +17     
============================================
+ Hits           3758     3853      +95     
- Misses          479      492      +13     
- Partials        177      185       +8     
Impacted Files Coverage Δ
...xception/DeleteModelWhenInTrainStateException.java 100.00% <ø> (ø)
...main/java/org/opensearch/knn/jni/FaissService.java 85.71% <ø> (ø)
...search/knn/plugin/rest/RestDeleteModelHandler.java 77.77% <0.00%> (ø)
...pensearch/knn/plugin/rest/RestGetModelHandler.java 77.77% <0.00%> (ø)
...earch/knn/plugin/transport/DeleteModelRequest.java 84.61% <0.00%> (ø)
...java/org/opensearch/knn/index/query/KNNScorer.java 55.00% <28.57%> (-14.24%) ⬇️
...rg/opensearch/knn/index/query/KNNQueryBuilder.java 84.31% <66.66%> (+0.10%) ⬆️
...java/org/opensearch/knn/index/query/KNNWeight.java 86.75% <86.20%> (-2.72%) ⬇️
...rg/opensearch/knn/index/query/KNNQueryFactory.java 90.47% <94.11%> (+0.47%) ⬆️
.../java/org/opensearch/knn/index/query/KNNQuery.java 91.42% <100.00%> (+8.09%) ⬆️
... and 7 more

... and 1 file with indirect coverage changes