[Backport-2.x] Enabled the efficient filtering support for Faiss Engine. #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es include (opensearch-project#936) * Enabled the efficient filtering support for Faiss Engine (opensearch-project#907) * Fixed the ef_search default value for faiss HNSW with filters and updated the perf-tool to include Faiss HNSW tests (opensearch-project#926) * Added exact search for cases when filteredIds < k to improve the recall for exact search (opensearch-project#928) * Improved Exact Search to return only K results and added client side latency metric for query Benchmarks (opensearch-project#933) * Added Integration Tests and Unit test for Efficient Filtering for Faiss Engine (opensearch-project#934) Signed-off-by: Navneet Verma <navneev@amazon.com>
navneet1v
requested review from
heemin32,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
…ct#942) Signed-off-by: Navneet Verma <navneev@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #960 +/- ##
============================================
- Coverage 85.13% 85.05% -0.09%
- Complexity 1088 1116 +28
============================================
Files 152 152
Lines 4414 4530 +116
Branches 392 409 +17
============================================
+ Hits 3758 3853 +95
- Misses 479 492 +13
- Partials 177 185 +8
|
martin-gaievski
approved these changes
Jul 10, 2023
junqiu-lei
approved these changes
Jul 10, 2023
|
Tests which are failing: Secure Cluster tests, Windows tests, mac-os tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled the efficient filtering support for Faiss Engine. This is a backport of: #936, #942 , #951
Issues Resolved
#903
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.