Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Set Default value for SIMD_ENABLED in CMakeList #1455

Merged

Conversation

naveentatikonda
Copy link
Member

Description

Cherry-picked db87edd from #1449

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e17711) 85.09% compared to head (ddc0fa1) 85.09%.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #1455   +/-   ##
=========================================
  Coverage     85.09%   85.09%           
  Complexity     1255     1255           
=========================================
  Files           162      162           
  Lines          5152     5152           
  Branches        495      495           
=========================================
  Hits           4384     4384           
  Misses          560      560           
  Partials        208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ryanbogan ryanbogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naveentatikonda naveentatikonda merged commit fc2c154 into opensearch-project:2.x Feb 5, 2024
86 checks passed
naveentatikonda added a commit to naveentatikonda/k-NN that referenced this pull request Feb 6, 2024
naveentatikonda added a commit to naveentatikonda/k-NN that referenced this pull request Feb 6, 2024
…roject#1455)"

This reverts commit fc2c154.

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda added a commit that referenced this pull request Feb 6, 2024
* Revert "Set Default value for SIMD_ENABLED in CMakeList (#1455)"

This reverts commit fc2c154.

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Revert "Add support for Faiss SQFP16 Quantization and enable AVX2 Optimization (#1421) (#1448)"

This reverts commit 0e17711.

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

---------

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants