-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Default value for SIMD_ENABLED in CMakeList #1449
Set Default value for SIMD_ENABLED in CMakeList #1449
Conversation
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
============================================
- Coverage 85.07% 85.05% -0.02%
+ Complexity 1278 1277 -1
============================================
Files 167 167
Lines 5207 5207
Branches 493 493
============================================
- Hits 4430 4429 -1
Misses 570 570
- Partials 207 208 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1449-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 db87eddd30c04e1353618c7dd4d1250b10f4e579
# Push it to GitHub
git push --set-upstream origin backport/backport-1449-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…roject#1449)" This reverts commit db87edd.
…roject#1449)" This reverts commit db87edd.
Description
Set Default value for
SIMD_ENABLED
asfalse
to stop failing and make this an optional argument while runningcmake .
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.