refactored classnames for sidebar #933

sumukhswamy · 2023-08-15T21:18:38Z

Changed all the classnames for the sidebar component to avoid conflicts

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

kavithacm · 2023-08-15T23:57:09Z

looks like the tests are failing. Can you take a look into it? @sumukhswamy

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

codecov · 2023-08-16T21:08:05Z

Codecov Report

Merging #933 (5a83233) into main (e947d4b) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   43.68%   43.68%           
=======================================
  Files         313      313           
  Lines       18698    18698           
  Branches     4554     4554           
=======================================
  Hits         8169     8169           
  Misses       9973     9973           
  Partials      556      556

Flag	Coverage Δ
dashboards-observability	`43.68% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

mengweieric

LGTM thanks

mengweieric · 2023-09-07T17:20:21Z

public/components/event_analytics/explorer/sidebar/sidebar.tsx

@@ -141,7 +141,7 @@ export const Sidebar = (props: ISidebarProps) => {
                  paddingSize="xs"
                >
                  <ul
-                    className="dscSidebarList dscFieldList--selected"
+                    className="dscSidebarList explorerFieldList--selected"


minor: could we also rename 'dscSidebarList' with similar pattern?

kavithacm · 2023-09-07T17:26:53Z

public/components/event_analytics/explorer/sidebar/sidebar.tsx

@@ -185,7 +185,7 @@ export const Sidebar = (props: ISidebarProps) => {
                paddingSize="xs"
              >
                <ul
-                  className="dscSidebarList dscFieldList--selected"
+                  className="dscSidebarList explorerFieldList--selected"


Same comment as Eric, could you rename this dscSidebarList as well?

kavithacm

minor changes

* refactored classnames for sidebar --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com>

* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 171acde)

sumukhswamy requested review from pjfitzgibbons, ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsi-amazon, Swiddis, penghuo, seankao-az and anirudha as code owners August 15, 2023 21:18

sumukhswamy added 2 commits August 16, 2023 10:40

refactored classnames for sidebar

8a3a9a8

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

changed snapshot back

bbf5514

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

sumukhswamy force-pushed the class-refactor branch from 43d900a to bbf5514 Compare August 16, 2023 17:42

updated snapshots

5a83233

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

mengweieric approved these changes Aug 21, 2023

View reviewed changes

mengweieric reviewed Sep 7, 2023

View reviewed changes

kavithacm reviewed Sep 7, 2023

View reviewed changes

kavithacm approved these changes Sep 7, 2023

View reviewed changes

pjfitzgibbons merged commit e7bdc67 into opensearch-project:main Sep 13, 2023
9 checks passed

pjfitzgibbons pushed a commit that referenced this pull request Sep 26, 2023

refactored classnames for sidebar (#933)

2913940

* refactored classnames for sidebar --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

derek-ho pushed a commit to derek-ho/dashboards-observability that referenced this pull request Oct 4, 2023

refactored classnames for sidebar (opensearch-project#933)

f242ed0

* refactored classnames for sidebar --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactored classnames for sidebar #933

refactored classnames for sidebar #933

sumukhswamy commented Aug 15, 2023 •

edited

Loading

kavithacm commented Aug 15, 2023

codecov bot commented Aug 16, 2023

mengweieric left a comment

mengweieric Sep 7, 2023

kavithacm Sep 7, 2023

kavithacm left a comment

refactored classnames for sidebar #933

refactored classnames for sidebar #933

Conversation

sumukhswamy commented Aug 15, 2023 • edited Loading

Check List

kavithacm commented Aug 15, 2023

codecov bot commented Aug 16, 2023

Codecov Report

mengweieric left a comment

Choose a reason for hiding this comment

mengweieric Sep 7, 2023

Choose a reason for hiding this comment

kavithacm Sep 7, 2023

Choose a reason for hiding this comment

kavithacm left a comment

Choose a reason for hiding this comment

sumukhswamy commented Aug 15, 2023 •

edited

Loading