Update UI for integrations setup #1052

Swiddis · 2023-09-27T00:04:23Z

Description

Per UX team feedback, this PR updates the UI for integrations setup, and also restores the original functionality for creating integrations. Integration tests still need to be rewritten and the validation functionality needs to be finished.

Issues Resolved

N/A

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

…atalog

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Let it be known at on this day, with this commit, I have truly grokked why we don't use `any` in typescript. Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

ps48

minor comments

public/components/integrations/components/__tests__/setup_integration.test.tsx

public/components/integrations/components/create_integration_helpers.ts

public/components/integrations/components/setup_integration.tsx

ps48 · 2023-09-29T23:25:32Z

public/components/integrations/components/setup_integration.tsx

+              setLoading(true);
+              const template = await findTemplate(integration.name);
+              await addIntegrationRequest(
+                false,
+                integration.name,
+                config.displayName,
+                template,
+                setToast,
+                config.displayName,
+                config.connectionDataSource
+              );
+              setLoading(false);


do you want to move this to a function?

Can you elaborate? Do you mean move this to a separate wrapper function that only gets used here?

Yes, move onclick part to a separate function: onClick={handleAddIntegration} . It is just 4 statements but linter makes it look like 12 lines. Just a suggestion.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

ps48 · 2023-10-03T18:16:46Z

common/constants/integrations.ts

+export const VALID_INDEX_NAME = /^[a-z\d\.][a-z\d\._\-\*]*$/;
+
+// Upstream doesn't export this, so we need to redeclare it for our use.
+export type Color = 'success' | 'primary' | 'warning' | 'danger' | undefined;


nit. Can add more descriptive name here TOAST_NOTIFICATION_COLOR

opensearch-trigger-bot · 2023-10-03T20:00:25Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1052-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7630b2d8a23fbbd6663ebd4b3eeb3132e72eb25f
# Push it to GitHub
git push --set-upstream origin backport/backport-1052-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1052-to-2.x.

* Stub catalog reader interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic catalog functionality to new catalog reader Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Generalize Result type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert backend to use catalog reader (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair tests for integrations class (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor repository for new integration interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix outer repository and backend tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for sample data Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add CatalogReader JavaDocs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair integrations builder Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove extra commented test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unnecessary log statement Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair getSchemas behavior to return correct type Let it be known at on this day, with this commit, I have truly grokked why we don't use `any` in typescript. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for getSchemas Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for asset and sample data backend methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Break flyout validation methods out of constructing method Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for extracted flyout methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch validation method to use ValidationResult Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Swap out flyout for hello-world setup page Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic step incrementing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic field skeleton for each step Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add a cancel button Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add config type to developing form Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Flatten integration config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add sample data table modal Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add toggle for standard and advanced asset config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor major class names Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * (WIP) begin refactoring functionality into adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Finish migrating functionality to data adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Rename integration types for more clarity Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor component usage Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Connect forms to config state Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix filetype selector Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove hardcoded name in path Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Write one snapshot test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add more tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix test naming Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update obsolete snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Move integration creation helpers to own file Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Break out integration creation methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Isolate more create_integration helpers Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify setup form Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add data source picker items Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add better selector logic Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add queries for data sources Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch from selector to combobox Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Connect validation button to data source validation method Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Reimplement add integration button Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Temporarily remove validate button Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify dynamic table term selection Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused validate code Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Undo wildcard import Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch from proxy to dataconnections endpoint Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused table fields Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch dataconnections base to const Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add console proxy to route constants Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Move color to constants Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Move index name validation to constants and improve matching Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Move test constants to test constants Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com>

* Stub catalog reader interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic catalog functionality to new catalog reader Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Generalize Result type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert backend to use catalog reader (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair tests for integrations class (unstable) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor repository for new integration interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix outer repository and backend tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for sample data Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add CatalogReader JavaDocs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair integrations builder Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove extra commented test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unnecessary log statement Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Repair getSchemas behavior to return correct type Let it be known at on this day, with this commit, I have truly grokked why we don't use `any` in typescript. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for getSchemas Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for asset and sample data backend methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Break flyout validation methods out of constructing method Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for extracted flyout methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch validation method to use ValidationResult Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Swap out flyout for hello-world setup page Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic step incrementing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic field skeleton for each step Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add a cancel button Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add config type to developing form Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Flatten integration config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add sample data table modal Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add toggle for standard and advanced asset config Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor major class names Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * (WIP) begin refactoring functionality into adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Finish migrating functionality to data adaptor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Rename integration types for more clarity Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor component usage Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Connect forms to config state Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix filetype selector Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove hardcoded name in path Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Write one snapshot test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add more tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix test naming Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update obsolete snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Move integration creation helpers to own file Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Break out integration creation methods Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Isolate more create_integration helpers Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify setup form Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add data source picker items Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add better selector logic Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add queries for data sources Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch from selector to combobox Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Connect validation button to data source validation method Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Reimplement add integration button Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Temporarily remove validate button Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Simplify dynamic table term selection Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused validate code Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Undo wildcard import Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch from proxy to dataconnections endpoint Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused table fields Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch dataconnections base to const Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add console proxy to route constants Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Move color to constants Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Move index name validation to constants and improve matching Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Move test constants to test constants Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 171acde)

Swiddis added 30 commits August 17, 2023 15:41

Stub catalog reader interface

c5cea8d

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Add basic catalog functionality to new catalog reader

77ad89b

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Refactor validation logic with a deeper interface

676591d

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Refactor validation logic with a deeper interface

12c4bcf

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Remove redundant test.

412480e

This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Add tests for new validators

6d2bad1

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Merge branch 'better-validation' into prototype-network-catalog

c3dd111

Make better failure mode for invalid objects

55d6490

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Merge branch 'main' into prototype-network-catalog

c62d28b

Generalize Result type

ba56fb8

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Convert backend to use catalog reader (unstable)

cb29208

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Repair tests for integrations class (unstable)

c9de36e

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Refactor repository for new integration interface

37c7980

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Fix outer repository and backend tests

b331090

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Add tests for sample data

4b29e17

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Merge remote-tracking branch 'upstream/main' into prototype-network-c…

b35dfa8

…atalog

Add CatalogReader JavaDocs

1bef29e

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Repair integrations builder

a18cf47

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Remove extra commented test

047b14a

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Remove unnecessary log statement

e65fe8b

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Repair getSchemas behavior to return correct type

00ddb5b

Let it be known at on this day, with this commit, I have truly grokked why we don't use `any` in typescript. Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Add tests for getSchemas

8af7f4a

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Add tests for asset and sample data backend methods

a31963d

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Break flyout validation methods out of constructing method

feeaef5

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Add tests for extracted flyout methods

b644d11

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Switch validation method to use ValidationResult

614613a

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Merge branch 'prototype-network-catalog' into feature/integrations-setup

d97b931

Merge branch 'refactor-integ-frontend' into feature/integrations-setup

c8b5eff

Merge branch 'main' into prototype-network-catalog

af78c27

Swap out flyout for hello-world setup page

ab30ed0

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Swiddis requested review from joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsi-amazon, penghuo, seankao-az and anirudha as code owners September 29, 2023 17:47

Swiddis requested review from ps48 and derek-ho September 29, 2023 17:52

Swiddis mentioned this pull request Sep 29, 2023

Setup S3 connection with integrations #1057

Merged

6 tasks

ps48 reviewed Sep 29, 2023

View reviewed changes

Swiddis added 3 commits October 3, 2023 10:26

Move color to constants

9a6dc3a

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Move index name validation to constants and improve matching

1e267c6

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Move test constants to test constants

7d4854e

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

ps48 reviewed Oct 3, 2023

View reviewed changes

ps48 approved these changes Oct 3, 2023

View reviewed changes

YANG-DB approved these changes Oct 3, 2023

View reviewed changes

YANG-DB merged commit 7630b2d into opensearch-project:main Oct 3, 2023
7 of 9 checks passed

YANG-DB added the backport 2.x label Oct 3, 2023

opensearch-trigger-bot bot added the backport-failed label Oct 3, 2023

YANG-DB added integrations Used to denote items related to the Integrations project and removed backport-failed backport 2.x labels Oct 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update UI for integrations setup #1052

Update UI for integrations setup #1052

Swiddis commented Sep 27, 2023

ps48 left a comment

ps48 Sep 29, 2023

Swiddis Oct 3, 2023

ps48 Oct 3, 2023

ps48 Oct 3, 2023

opensearch-trigger-bot bot commented Oct 3, 2023

Update UI for integrations setup #1052

Update UI for integrations setup #1052

Conversation

Swiddis commented Sep 27, 2023

Description

Issues Resolved

Check List

ps48 left a comment

Choose a reason for hiding this comment

ps48 Sep 29, 2023

Choose a reason for hiding this comment

Swiddis Oct 3, 2023

Choose a reason for hiding this comment

ps48 Oct 3, 2023

Choose a reason for hiding this comment

ps48 Oct 3, 2023

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Oct 3, 2023