Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix create acceleration bugs #1602

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 76d206c from #1599.

* fix acceleration flyout minor bugs

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update index name regex

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 76d206c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 58.03%. Comparing base (800f7b2) to head (a0f2647).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...rations_flyout/selectors/index_setting_options.tsx 0.00% 5 Missing ⚠️
...rations_flyout/selectors/preview_sql_defintion.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1602      +/-   ##
==========================================
- Coverage   58.05%   58.03%   -0.03%     
==========================================
  Files         365      365              
  Lines       13621    13626       +5     
  Branches     3587     3587              
==========================================
  Hits         7908     7908              
- Misses       5650     5655       +5     
  Partials       63       63              
Flag Coverage Δ
dashboards-observability 58.03% <25.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit e089310 into 2.x Mar 21, 2024
21 of 34 checks passed
@github-actions github-actions bot deleted the backport/backport-1599-to-2.x branch March 21, 2024 00:16
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…n set within the current request (opensearch-project#1580) (opensearch-project#1602)

Signed-off-by: Jochen Kressin <jochen.kressin-gh@eliatra.com>
Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
(cherry picked from commit d575e0001c406149a9df6e6c52c00057738e7536)

Co-authored-by: Jochen Kressin <126353411+jochen-kressin@users.noreply.github.com>
Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants