Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create acceleration bugs #1599

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Mar 20, 2024

Description

Fix create acceleration bugs

Issues Resolved

  1. Update Continue in SQL workbench butotn
  2. Update Index name regex and description
  3. Update acceleration type wordings in selector
  4. Fix non error state for refresh type change

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 57.74%. Comparing base (2bc9c17) to head (de8aec0).
Report is 1 commits behind head on main.

Files Patch % Lines
...rations_flyout/selectors/index_setting_options.tsx 0.00% 5 Missing ⚠️
...rations_flyout/selectors/preview_sql_defintion.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
- Coverage   57.76%   57.74%   -0.03%     
==========================================
  Files         367      367              
  Lines       13808    13813       +5     
  Branches     3621     3621              
==========================================
  Hits         7976     7976              
- Misses       5769     5774       +5     
  Partials       63       63              
Flag Coverage Δ
dashboards-observability 57.74% <25.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit 76d206c into opensearch-project:main Mar 21, 2024
13 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 21, 2024
* fix acceleration flyout minor bugs

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update index name regex

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 76d206c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 21, 2024
* fix acceleration flyout minor bugs

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update index name regex

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 76d206c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ps48 ps48 removed the enhancement New feature or request label Mar 21, 2024
@ps48 ps48 added the bug Something isn't working label Mar 21, 2024
ps48 pushed a commit that referenced this pull request Mar 21, 2024
* fix acceleration flyout minor bugs



* update snapshots



* update index name regex



---------


(cherry picked from commit 76d206c)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 21, 2024
* fix acceleration flyout minor bugs



* update snapshots



* update index name regex



---------


(cherry picked from commit 76d206c)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…oject#1603)

* fix acceleration flyout minor bugs

* update snapshots

* update index name regex

---------

(cherry picked from commit 76d206c)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit b17afd3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants