Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.13] Update loading state for tables fields in create acceleration flyout #1581

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport cffc104 from #1576.

…1576)

* update loading state for tables fields

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit cffc104)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 58.15%. Comparing base (cb78382) to head (97be80e).

Files Patch % Lines
...flyout/selectors/selector_helpers/load_objects.tsx 50.00% 2 Missing ⚠️
...ccelerations_flyout/create/create_acceleration.tsx 66.66% 1 Missing ⚠️
...yout/selectors/selector_helpers/load_databases.tsx 66.66% 1 Missing ⚠️
...ions_flyout/visual_editors/query_visual_editor.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             2.13    #1581   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files         365      365           
  Lines       13549    13561   +12     
  Branches     3562     3565    +3     
=======================================
+ Hits         7880     7887    +7     
- Misses       5605     5610    +5     
  Partials       64       64           
Flag Coverage Δ
dashboards-observability 58.15% <58.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit 2e9d20c into 2.13 Mar 20, 2024
23 of 34 checks passed
@github-actions github-actions bot deleted the backport/backport-1576-to-2.13 branch March 20, 2024 02:22
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…pensearch-project#1576) (opensearch-project#1581)

* update loading state for tables fields

* update snapshots

---------

(cherry picked from commit cffc104)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 2e9d20c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants