Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loading state for tables fields in create acceleration flyout #1576

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Mar 20, 2024

Description

Update loading state for tables fields in create acceleration flyout

Issues Resolved

  1. Reset fields in acceleration create workflow when fields change
  2. Update loading state to be in definitions instead of flyout
  3. On unmount stop loaders

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 57.83%. Comparing base (73899a2) to head (5710a22).
Report is 1 commits behind head on main.

Files Patch % Lines
...flyout/selectors/selector_helpers/load_objects.tsx 50.00% 2 Missing ⚠️
...ccelerations_flyout/create/create_acceleration.tsx 66.66% 1 Missing ⚠️
...yout/selectors/selector_helpers/load_databases.tsx 66.66% 1 Missing ⚠️
...ions_flyout/visual_editors/query_visual_editor.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1576      +/-   ##
==========================================
- Coverage   57.84%   57.83%   -0.01%     
==========================================
  Files         367      367              
  Lines       13760    13781      +21     
  Branches     3603     3612       +9     
==========================================
+ Hits         7959     7970      +11     
- Misses       5738     5747       +9     
- Partials       63       64       +1     
Flag Coverage Δ
dashboards-observability 57.83% <58.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit cffc104 into opensearch-project:main Mar 20, 2024
17 of 24 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
…1576)

* update loading state for tables fields

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit cffc104)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 20, 2024
…1576) (#1578)

* update loading state for tables fields



* update snapshots



---------


(cherry picked from commit cffc104)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
…1576)

* update loading state for tables fields

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit cffc104)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 20, 2024
…1576) (#1581)

* update loading state for tables fields



* update snapshots



---------


(cherry picked from commit cffc104)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…pensearch-project#1576) (opensearch-project#1581)

* update loading state for tables fields

* update snapshots

---------

(cherry picked from commit cffc104)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 2e9d20c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants