[Backport 2.x] Fixed small bugs in explorer #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* disable ppl direct query autocomplete Signed-off-by: Paul Sebastian <paulstn@amazon.com> * disable sorting for s3 Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix pagination for s3 Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix flyout to use actual row doc Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix surrounding events Signed-off-by: Paul Sebastian <paulstn@amazon.com> * allow for surrounding fields to work on s3 Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix lint complaint Signed-off-by: Paul Sebastian <paulstn@amazon.com> * const instead of let Signed-off-by: Paul Sebastian <paulstn@amazon.com> * changed naming for isDataSource bool Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update snapshot Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 3cec4dc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1571 +/- ##
==========================================
- Coverage 58.15% 58.14% -0.02%
==========================================
Files 365 365
Lines 13549 13554 +5
Branches 3562 3564 +2
==========================================
+ Hits 7880 7881 +1
- Misses 5605 5609 +4
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ps48
approved these changes
Mar 20, 2024
mengweieric
approved these changes
Mar 20, 2024
RyanL1997
pushed a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…ct#1571) Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit ecb15d56aa96c549f1fd0ca07c86e677cbe6ddbc) Co-authored-by: Miki <miki@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3cec4dc from #1559.