Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed small bugs in explorer #1559

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Fixed small bugs in explorer #1559

merged 11 commits into from
Mar 19, 2024

Conversation

paulstn
Copy link
Collaborator

@paulstn paulstn commented Mar 18, 2024 •
edited
Loading

Description

  • For s3 data sources, disabled sorting
  • Disabled autocomplete for s3 ppl
  • For s3, implemented basic working pagination
  • In default data sources: Explorer data grid fix flyout after sort correspond to correct row
  • Fix/reenable surrounding events
  • Create ability for surrounding events to work on s3

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@paulstn
disable ppl direct query autocomplete
651f0d0 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
disable sorting for s3
d4938e9 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
fix pagination for s3
5655a86 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
fix flyout to use actual row doc
ce70b3a 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
fix surrounding events
34c723c 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn paulstn added enhancement New feature or request backport 2.x labels Mar 18, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 57.84%. Comparing base (26e8610) to head (1361aef).
Report is 3 commits behind head on main.

Files Patch % Lines
...vent_analytics/explorer/events_views/data_grid.tsx 16.66% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
+ Coverage   57.79%   57.84%   +0.05%     
==========================================
  Files         364      366       +2     
  Lines       13414    13644     +230     
  Branches     3479     3557      +78     
==========================================
+ Hits         7752     7892     +140     
- Misses       5603     5691      +88     
- Partials       59       61       +2
Flag Coverage Δ
dashboards-observability 57.84% <16.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulstn
fix lint complaint
8ee0d51 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn paulstn marked this pull request as ready for review March 18, 2024 21:08
@paulstn paulstn marked this pull request as draft March 18, 2024 21:08
@paulstn paulstn marked this pull request as ready for review March 18, 2024 21:09
@paulstn
const instead of let
ec296b3 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
changed naming for isDataSource bool
7e8634f 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@ps48
Copy link
Member

ps48 commented Mar 19, 2024

@paulstn Can you please look into build errors?

@paulstn
update snapshot
1361aef 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn paulstn merged commit 3cec4dc into opensearch-project:main Mar 19, 2024
14 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 19, 2024
@github-actions
Fixed small bugs in explorer (#1559)
ab83c34 
* disable ppl direct query autocomplete

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* disable sorting for s3

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix pagination for s3

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix flyout to use actual row doc

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix surrounding events

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* allow for surrounding fields to work on s3

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix lint complaint

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* const instead of let

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* changed naming for isDataSource bool

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update snapshot

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
(cherry picked from commit 3cec4dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 19, 2024
Merged
mengweieric pushed a commit that referenced this pull request Mar 20, 2024
@opensearch-trigger-bot @github-actions
Fixed small bugs in explorer (#1559) (#1571)
770684d 
* disable ppl direct query autocomplete



* disable sorting for s3



* fix pagination for s3



* fix flyout to use actual row doc



* fix surrounding events



* allow for surrounding fields to work on s3



* fix lint complaint



* const instead of let



* changed naming for isDataSource bool



* update snapshot



---------


(cherry picked from commit 3cec4dc)

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
@github-actions
Fixed small bugs in explorer (#1559)
83e166d 
* disable ppl direct query autocomplete

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* disable sorting for s3

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix pagination for s3

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix flyout to use actual row doc

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix surrounding events

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* allow for surrounding fields to work on s3

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fix lint complaint

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* const instead of let

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* changed naming for isDataSource bool

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update snapshot

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
(cherry picked from commit 3cec4dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 20, 2024
Merged
ps48 added a commit that referenced this pull request Mar 20, 2024
@opensearch-trigger-bot @github-actions @ps48
Fixed small bugs in explorer (#1559) (#1580)
75e91db 
* disable ppl direct query autocomplete



* disable sorting for s3



* fix pagination for s3



* fix flyout to use actual row doc



* fix surrounding events



* allow for surrounding fields to work on s3



* fix lint complaint



* const instead of let



* changed naming for isDataSource bool



* update snapshot



---------


(cherry picked from commit 3cec4dc)

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
@opensearch-trigger-bot @cwperks
Update or remove instances of hardcoded colors (opensearch-project#1558…
d0ec8fe 
…) (opensearch-project#1559)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit c10031f956ebb05d2f11424e7ddf1552d7a5cb0d)

Co-authored-by: Craig Perkins <cwperx@amazon.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
@opensearch-trigger-bot
Fixed small bugs in explorer (opensearch-project#1559) (opensearch-pr…
a6b0dc4 
…oject#1580)

* disable ppl direct query autocomplete

* disable sorting for s3

* fix pagination for s3

* fix flyout to use actual row doc

* fix surrounding events

* allow for surrounding fields to work on s3

* fix lint complaint

* const instead of let

* changed naming for isDataSource bool

* update snapshot

---------

(cherry picked from commit 3cec4dc)

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 75e91db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiddis Swiddis Swiddis approved these changes

@ps48 ps48 ps48 approved these changes

@RyanL1997 RyanL1997 RyanL1997 approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm

@derek-ho derek-ho Awaiting requested review from derek-ho

@joshuali925 joshuali925 Awaiting requested review from joshuali925

@dai-chen dai-chen Awaiting requested review from dai-chen

@YANG-DB YANG-DB Awaiting requested review from YANG-DB

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon

@penghuo penghuo Awaiting requested review from penghuo

@seankao-az seankao-az Awaiting requested review from seankao-az

@anirudha anirudha Awaiting requested review from anirudha

@sumukhswamy sumukhswamy Awaiting requested review from sumukhswamy

Assignees
No one assigned
Labels
backport 2.x backport 2.13 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulstn @ps48 @Swiddis @RyanL1997