Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport main] Bugfix/metric-loading-loop (#1309) #1318

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

pjfitzgibbons
Copy link
Contributor

Description

Badkport #1309 "Metric Loading Loop fix" to main

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (f31d969) 57.42% compared to head (a600697) 57.39%.

Files Patch % Lines
...isualization_container/visualization_container.tsx 37.50% 5 Missing ⚠️
public/components/custom_panels/helpers/utils.tsx 25.00% 3 Missing ⚠️
public/components/metrics/sidebar/sidebar.tsx 0.00% 3 Missing ⚠️
public/components/metrics/view/metrics_grid.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
- Coverage   57.42%   57.39%   -0.03%     
==========================================
  Files         330      330              
  Lines       12091    12099       +8     
  Branches     2792     2796       +4     
==========================================
+ Hits         6943     6944       +1     
- Misses       5102     5109       +7     
  Partials       46       46              
Flag Coverage Δ
dashboards-observability 57.39% <58.82%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 changed the title Backport #1309 to main [Backport main] Bugfix/metric-loading-loop (#1309) Dec 21, 2023
@ps48
Copy link
Member

ps48 commented Dec 21, 2023

Lint CI is failing here due to a configuration change pending in PR: #1317

@pjfitzgibbons pjfitzgibbons merged commit 7e314d2 into main Dec 21, 2023
14 of 31 checks passed
@github-actions github-actions bot deleted the backport/metric-loading-loop-to-main branch December 21, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants