Bugfix/metric-loading-loop #1309
Conversation
…isualizationContainer when Promql metric Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
* Visualization action-menu correction for OSD Dashboards context and Menu Explorer context * Visualization of Promql metric navigate to Metric Explorer on "Edit" * Metric Explorer correct loading of metric by URL Id Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
pjfitzgibbons
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1309 +/- ##
==========================================
+ Coverage 56.42% 57.44% +1.02%
==========================================
Files 327 330 +3
Lines 11930 12094 +164
Branches 2740 2793 +53
==========================================
+ Hits 6732 6948 +216
+ Misses 5153 5100 -53
- Partials 45 46 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -43,10 +43,12 @@ export const Sidebar = ({ | |||
|
|
|||
| useEffect(() => { | |||
| if (additionalMetric) { | |||
There was a problem hiding this comment.
what's an additional metric?
There was a problem hiding this comment.
A badly named variable.
It's used when navigating to a specific metric for "edit", the URL is ./metrics/{savedObjectId}.
I tried a bunch fo names that didn't work and then just gave up trying. (Not the best approach)
|
@pjfitzgibbons Is this already merged to main or are we pending a forward port? @kavithacm @YANG-DB can you please make sure the accurate backport labels are in before you review the PRs? We have missed the backports before that have caused last minute merge issues during the release timeframe |
|
Yes, missing forward backport (ugh, the terminology!) |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-main main
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-main
# Create a new branch
git switch --create backport/backport-1309-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fd55726896e9785d0a9a352b520df0e7cb16d1e5
# Push it to GitHub
git push --set-upstream origin backport/backport-1309-to-main
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-mainThen, create a pull request where the |
OR forward backport main 🤣 |
* Metric workflow fixes * Visualization action-menu correction for OSD Dashboards context and Menu Explorer context * Visualization of Promql metric navigate to Metric Explorer on "Edit" * Metric Explorer correct loading of metric by URL Id --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> (cherry picked from commit fd55726)
Description
Found several bugs in Metric workflow during validation of recent PR
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.