Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build.sh #483

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Add build.sh #483

merged 2 commits into from
Aug 19, 2022

Conversation

prudhvigodithi
Copy link
Contributor

@prudhvigodithi prudhvigodithi commented Aug 17, 2022

Description

Default build.sh in build repo for 1.3.x includes task publishPluginZipPublicationToZipStagingRepository.

Issues Resolved

opensearch-project/opensearch-build#2470

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
@prudhvigodithi prudhvigodithi requested a review from a team August 17, 2022 19:31
@prudhvigodithi prudhvigodithi mentioned this pull request Aug 17, 2022
5 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #483 (660291c) into 1.3 (e88a36f) will decrease coverage by 1.66%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #483      +/-   ##
============================================
- Coverage     74.86%   73.20%   -1.67%     
+ Complexity     1002      985      -17     
============================================
  Files           141      141              
  Lines          4575     4575              
  Branches        509      509              
============================================
- Hits           3425     3349      -76     
- Misses          834      914      +80     
+ Partials        316      312       -4     
Impacted Files Coverage Δ
...ch/replication/task/index/IndexReplicationState.kt 51.66% <0.00%> (-15.00%) ⬇️
...ication/action/setup/TransportSetupChecksAction.kt 59.52% <0.00%> (-14.29%) ⬇️
...ication/seqno/RemoteClusterRetentionLeaseHelper.kt 80.00% <0.00%> (-11.67%) ⬇️
...tion/repository/RemoteClusterMultiChunkTransfer.kt 90.24% <0.00%> (-9.76%) ⬇️
.../replication/metadata/store/ReplicationMetadata.kt 62.96% <0.00%> (-8.65%) ⬇️
...ication/action/stop/StopIndexReplicationRequest.kt 50.00% <0.00%> (-5.00%) ⬇️
...ion/action/resume/ResumeIndexReplicationRequest.kt 50.00% <0.00%> (-5.00%) ⬇️
...tlin/org/opensearch/replication/util/Extensions.kt 65.47% <0.00%> (-4.77%) ⬇️
...on/action/index/ReplicateIndexMasterNodeRequest.kt 50.00% <0.00%> (-4.17%) ⬇️
...ication/action/setup/ValidatePermissionsRequest.kt 62.50% <0.00%> (-4.17%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dblock
Copy link
Member

dblock commented Aug 17, 2022

The build failure is reproducible here. Someone needs to look into it.

/home/runner/work/cross-cluster-replication/cross-cluster-replication/security/src/test/java/org/opensearch/security/AdvancedSecurityMigrationTests.java:194: warning: non-varargs call of varargs method with inexact argument type for last parameter;

> Task :compileTestJava
        res = rh.executeGetRequest("/_cluster/health", null);

@ankitkala
Copy link
Member

The build failure is reproducible here. Someone needs to look into it.

/home/runner/work/cross-cluster-replication/cross-cluster-replication/security/src/test/java/org/opensearch/security/AdvancedSecurityMigrationTests.java:194: warning: non-varargs call of varargs method with inexact argument type for last parameter;

> Task :compileTestJava
        res = rh.executeGetRequest("/_cluster/health", null);

Looks like security tests on 1.3 are failing. I can see that same line on main has the null param removed.

@saikaranam-amazon
Copy link
Member

I think the error is due to tracking version of 1.3.5 on 1.3 branch of security

13 actionable tasks: 12 executed, 1 up-to-date
cp: cannot stat 'build/distributions/opensearch-security-1.3.4.0.zip': No such file or directory
Error: Process completed with exit code 1.

@ankitkala
Copy link
Member

I think the error is due to tracking version of 1.3.5 on 1.3 branch of security

13 actionable tasks: 12 executed, 1 up-to-date
cp: cannot stat 'build/distributions/opensearch-security-1.3.4.0.zip': No such file or directory
Error: Process completed with exit code 1.

Correct. Raised a PR for version bump first: #484

@ankitkala
Copy link
Member

@prudhvigodithi Can you rebase the PR once so that CCR builds for 1.3.5?

@prudhvigodithi
Copy link
Contributor Author

@prudhvigodithi Can you rebase the PR once so that CCR builds for 1.3.5?

Hey @ankitkala, I just did.

@ankitkala ankitkala merged commit f6c862b into opensearch-project:1.3 Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants