-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common utils to support Microsoft teams in notifications #428
common utils to support Microsoft teams in notifications #428
Conversation
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Signed-off-by: dankyalo599 <johbiento@gmail.com>
Signed-off-by: dankyalo599 <johbiento@gmail.com>
Signed-off-by: dankyalo599 <johbiento@gmail.com>
…osoft_teams Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #428 +/- ##
============================================
+ Coverage 74.48% 74.60% +0.12%
- Complexity 859 868 +9
============================================
Files 129 130 +1
Lines 5597 5632 +35
Branches 684 689 +5
============================================
+ Hits 4169 4202 +33
Misses 1124 1124
- Partials 304 306 +2
|
PR in notifications: opensearch-project/notifications#676, opensearch-project/notifications#699 |
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Hi team, please help review and add backport 2.x label. |
@opensearch-project/common-utils Could someone help review this PR? Thanks! |
Hi @lezzago @qreshi @AWSHurneyt , you contributed many codes to the notifications plugin and are familiar with it. Could you please take a look and help review this PR? Thanks! |
@zhichao-aws has this been tested locally with the Notification plugin to ensure the new channel works? |
@lezzago Yes, we test the function locally and here are some screenshots: |
@AWSHurneyt @lezzago could you help to merge it and add backport 2.x label? |
* Added common utils for microsoft teams Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added configType ,eventstatus,configDataProperties and msTeams files Signed-off-by: dankyalo599 <johbiento@gmail.com> * Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams Signed-off-by: dankyalo599 <johbiento@gmail.com> * fix build Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix build, add more test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * change strings import Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix after core Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: dankyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> (cherry picked from commit bae1bee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Added common utils for microsoft teams * Added configType ,eventstatus,configDataProperties and msTeams files * Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams * fix build * fix build, add more test * change strings import * fix after core --------- (cherry picked from commit bae1bee) Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: dankyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com>
…project#428) (opensearch-project#512) * Added common utils for microsoft teams * Added configType ,eventstatus,configDataProperties and msTeams files * Added ConfigType,EventStatus,ConfigDataProperties and MicrosoftTeams * fix build * fix build, add more test * change strings import * fix after core --------- (cherry picked from commit bae1bee) Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: dankyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Description
Add common utils to support Microsoft teams in notifications plugin
Issues Resolved
opensearch-project/notifications#585
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.