Added common utils for microsoft teams #374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
|
Hi @dankyalo599 Are we still working on this PR? Looks like the workflow checks failed. Can we address this in the meantime while I get some attention on the review. |
|
There are ktlint errors that need to be fixed |
Yes we are still working on this PR |
Signed-off-by: dankyalo599 <johbiento@gmail.com>
Signed-off-by: dankyalo599 <johbiento@gmail.com>
Signed-off-by: dankyalo599 <johbiento@gmail.com>
dblock
reviewed
Apr 20, 2023
| */ | ||
| data class MicrosoftTeams( | ||
| val url: String | ||
| >>>>>>> b13bf3d337f15337a3c6999c5285482a79fd5a5d |
There was a problem hiding this comment.
Looks like you have code merge conflicts here.
|
Hi, I create a new PR to fix the build and add more test case. PR in notifications: opensearch-project/notifications#676 |
|
Looks like this was covered by #428. Closing, please reopen if I misunderstood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add common utils for microsoft teams
Issues Resolved
Add class and unit tests for microsoft teams common utils
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.