Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on JDK 8, 11, and 14. #106

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Mar 11, 2022

Signed-off-by: dblock dblock@dblock.org

Description

#104 for 1.3.

Issues Resolved

Closes #66.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock requested a review from a team as a code owner March 11, 2022 17:26
@dblock dblock changed the base branch from main to 1.3 March 11, 2022 17:26
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (1.3@229a84a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 10614dc differs from pull request most recent head 0211c59. Consider uploading reports for the commit 0211c59 to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##             1.3     #106   +/-   ##
======================================
  Coverage       ?   83.52%           
  Complexity     ?      555           
======================================
  Files          ?       61           
  Lines          ?     2058           
  Branches       ?      146           
======================================
  Hits           ?     1719           
  Misses         ?      234           
  Partials       ?      105           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229a84a...0211c59. Read the comment docs.

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dblock for the changes

@Bukhtawar Bukhtawar merged commit de65b7a into opensearch-project:1.3 Mar 11, 2022
@dblock dblock deleted the 1.3-jdk8 branch March 11, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default CI Java Version to Java 11, run tests on 8, 14 and 17
4 participants