Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on JDK 8, 11, 14 #104

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Build on JDK 8, 11, 14 #104

merged 1 commit into from
Mar 11, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Mar 11, 2022

Signed-off-by: dblock dblock@dblock.org

Description

Added CI for JDK 8, 11 and 14.

Issues Resolved

Closes #66.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Contributor

reta commented Mar 11, 2022

@dblock same for JDK-17, we need Gradle 7 but Welcome to Gradle 6.7.1! :-)

@dblock dblock changed the title Build on JDK 8, 11, 14 and 17. Build on JDK 8, 11, 14 Mar 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@229a84a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 18949ec differs from pull request most recent head 2830c7f. Consider uploading reports for the commit 2830c7f to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage        ?   83.77%           
  Complexity      ?      558           
=======================================
  Files           ?       61           
  Lines           ?     2058           
  Branches        ?      146           
=======================================
  Hits            ?     1724           
  Misses          ?      230           
  Partials        ?      104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229a84a...2830c7f. Read the comment docs.

reta
reta previously approved these changes Mar 11, 2022
build.gradle Outdated Show resolved Hide resolved
Signed-off-by: dblock <dblock@dblock.org>
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dblock for picking this up

@dblock dblock requested a review from amitgalitz March 11, 2022 17:05
This was referenced Mar 11, 2022
@Bukhtawar Bukhtawar merged commit c6d6a8c into opensearch-project:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default CI Java Version to Java 11, run tests on 8, 14 and 17
5 participants