[Feature/extensions] Migrates Get Detector action to extension #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
joshpalis
reviewed
Feb 15, 2023
src/main/java/org/opensearch/ad/transport/GetAnomalyDetectorTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/transport/GetAnomalyDetectorTransportAction.java
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
* Reformatting the imports Signed-off-by: Varun Jain <varunudr@amazon.com> * Reformatting imports and rebasing with SDK Signed-off-by: Varun Jain <varunudr@amazon.com> * Reformatting imports and rebasing with SDK Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
owaiskazi19
force-pushed
the
get-detector-extensions
branch
from
cb707d2
to
a64f199
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## feature/extensions #810 +/- ##
========================================================
- Coverage 53.33% 49.17% -4.16%
+ Complexity 2658 2631 -27
========================================================
Files 291 297 +6
Lines 16061 17113 +1052
Branches 1686 1843 +157
========================================================
- Hits 8566 8416 -150
- Misses 6877 8088 +1211
+ Partials 618 609 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshpalis
reviewed
Feb 16, 2023
joshpalis
approved these changes
Feb 16, 2023
dbwiddis
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the GetAnomalyDetectorTransportAction, their Rest Handlers, and other supporting classes from plugin to extension.
This PR also brings back the original index name for
ANOMALY_DETECTORS_INDEXfromopendistro-anomaly-detectors->.opendistro-anomaly-detectorsRemoved unused files:
RestGetDetectorAction,RestCreateDetectorActionandRestValidateDetectorActionIssues Resolved
Fixes opensearch-project/opensearch-sdk-java#373
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.