Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Reformatting the imports #806

Merged

Conversation

vibrantvarun
Copy link
Member

Signed-off-by: Varun Jain varunudr@amazon.com

Description

Reformatting the imports

Companion PR:
opensearch-project/job-scheduler#312

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Varun Jain <varunudr@amazon.com>
@vibrantvarun vibrantvarun marked this pull request as ready for review February 15, 2023 00:26
@vibrantvarun vibrantvarun requested a review from a team February 15, 2023 00:26
@owaiskazi19 owaiskazi19 changed the title Reformatting the imports [Feature/extensions] Reformatting the imports Feb 15, 2023
Signed-off-by: Varun Jain <varunudr@amazon.com>
@joshpalis joshpalis self-requested a review February 15, 2023 19:54
Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to modify the transport imports for the test files as well in order to pass the checks

Signed-off-by: Varun Jain <varunudr@amazon.com>
@joshpalis joshpalis merged commit 27bdf53 into opensearch-project:feature/extensions Feb 15, 2023
@vibrantvarun vibrantvarun deleted the Reformatting branch February 15, 2023 20:25
owaiskazi19 pushed a commit to owaiskazi19/anomaly-detection that referenced this pull request Feb 15, 2023
* Reformatting the imports

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Reformatting imports and rebasing with SDK

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Reformatting imports and rebasing with SDK

Signed-off-by: Varun Jain <varunudr@amazon.com>

---------

Signed-off-by: Varun Jain <varunudr@amazon.com>
joshpalis pushed a commit that referenced this pull request Feb 16, 2023
* Implemented Get Detector for AD Extension

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Added tests

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Removed unused file

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Changed extensionRunner to use its getter

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Removed try/catch for addSettingsUpdateConsumer

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* [Feature/extensions] Reformatting the imports (#806)

* Reformatting the imports

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Reformatting imports and rebasing with SDK

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Reformatting imports and rebasing with SDK

Signed-off-by: Varun Jain <varunudr@amazon.com>

---------

Signed-off-by: Varun Jain <varunudr@amazon.com>

* Removed unused file

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

---------

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Co-authored-by: Varun Jain <varunudr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants