Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.3.5] Add build.sh #641

Merged
merged 10 commits into from
Aug 17, 2022
Merged

Conversation

prudhvigodithi
Copy link
Contributor

Description

Default build.sh in build repo for 1.3.x includes task publishPluginZipPublicationToZipStagingRepository.

Issues Resolved

opensearch-project/opensearch-build#2470

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
dblock
dblock previously requested changes Aug 17, 2022
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 1 commit, not 10.

@Zhangxunmt
Copy link
Contributor

please squash the 10 commits when merging.

@ohltyler ohltyler requested a review from dblock August 17, 2022 18:56
@ohltyler ohltyler dismissed dblock’s stale review August 17, 2022 18:58

Can squash when merging

@ohltyler ohltyler merged commit 7475ab8 into opensearch-project:1.3 Aug 17, 2022
@dblock
Copy link
Member

dblock commented Aug 17, 2022

Any plans to fix flaky CI? In this PR none of the CI runs succeeded.

@ohltyler
Copy link
Member

ohltyler commented Aug 17, 2022

All tests are failing due to issues bringing up a cluster for some reason, and a likely-related issue about AD plugin not being installed:

org.opensearch.ad.common.exception.EndRunException: AD plugin is disabled. To enable update plugins.anomaly_detection.enabled to true

Made a note of it here: #640 (review), looking into it. Something related to 1.3 only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants