Build job-scheduler dependency in CI vs. zip #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
build-job-scheduler
branch
from
feaa18f
to
38011e5
Compare
ylwu-amzn
reviewed
Apr 26, 2021
| @@ -53,6 +53,12 @@ jobs: | |||
| - name: Build job-scheduler | |||
| working-directory: ./job-scheduler | |||
| run: ./gradlew publishToMavenLocal -Dopensearch.version=1.0.0-alpha1 -Dbuild.snapshot=false | |||
| - name: Assemble job-scheduler | |||
There was a problem hiding this comment.
From the error of https://github.com/opensearch-project/anomaly-detection/pull/25/checks?check_run_id=2440286543
Could not find com.amazon.opendistroforelasticsearch:opendistro-job-scheduler-spi:1.0.0.0.
We should build job scheduler SPI as well.
There was a problem hiding this comment.
The real issue here is that github checkout deletes everything in the current folder when checking out
Deleting the contents of '/home/runner/work/anomaly-detection/anomaly-detection'
7c4838a
to
bb96479
Compare
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
build-job-scheduler
branch
from
bb96479
to
b2a1e78
Compare
|
This is ready to review @ylwu-amzn! |
dblock
changed the title
ylwu-amzn
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@amazon.com
Description
Build and use job-scheduler artifact used in local integration testing instead of having a .zip version checked in. This avoids problems described in #26 and having to always manually add job-scheduler.zip every time we upgrade the dependency.
I switched the order of checkout for code because every time GitHub checkout@v2 runs in a folder it runs a
git cleanthat removes all un-versioned files.Issues Resolved
Closes #17.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.