-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build job-scheduler dependency in CI vs. zip #25
Conversation
feaa18f
to
38011e5
Compare
@@ -53,6 +53,12 @@ jobs: | |||
- name: Build job-scheduler | |||
working-directory: ./job-scheduler | |||
run: ./gradlew publishToMavenLocal -Dopensearch.version=1.0.0-alpha1 -Dbuild.snapshot=false | |||
- name: Assemble job-scheduler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the error of https://github.com/opensearch-project/anomaly-detection/pull/25/checks?check_run_id=2440286543
Could not find com.amazon.opendistroforelasticsearch:opendistro-job-scheduler-spi:1.0.0.0.
We should build job scheduler SPI as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real issue here is that github checkout deletes everything in the current folder when checking out
Deleting the contents of '/home/runner/work/anomaly-detection/anomaly-detection'
7c4838a
to
bb96479
Compare
Signed-off-by: dblock <dblock@amazon.com>
bb96479
to
b2a1e78
Compare
This is ready to review @ylwu-amzn! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the change!
Signed-off-by: dblock dblock@amazon.com
Description
Build and use job-scheduler artifact used in local integration testing instead of having a .zip version checked in. This avoids problems described in #26 and having to always manually add job-scheduler.zip every time we upgrade the dependency.
I switched the order of checkout for code because every time GitHub checkout@v2 runs in a folder it runs a
git clean
that removes all un-versioned files.Issues Resolved
Closes #17.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.