-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Checked in versions of job-scheduler-*-SNAPSHOT.zip #17
Comments
Not sure why I closed this, this is a major pain in version increments, e.g. #344, and whatever was done isn't working. |
This seems to be overlapping with #352, do you have a preference to which issue I should close. Currently I opened this issue in opensearch-build (https://github.com/opensearch-project/opensearch-build/issues/1441) in hopes to have job-scheduler snapshots always up to date in maven. In this issue are you suggesting a change to have the zips themselves uploaded to maven? |
I closed #352 since it's newer. |
Here's a full list of ZIPs.
This is now a child of opensearch-project/opensearch-build#1750 |
I am still seeing these:
|
@dblock The left over zips are for BWC. From a different issue I understand backfilling is a problem. I can either Implement code that parses manifests files for older zips or I can get the build numbers from the official docker releases. Is there a preferences between the two? |
@amitgalitz I think you should do something like opensearch-project/cross-cluster-replication#366. Right now you're using "some" -SNAPSHOT builds, which is precisely the issue. |
Is your feature request related to a problem? Please describe.
We commit the job-scheduler depenency into src/test/resources/job-scheduler/opendistro-job-scheduler-1.15.0.0-SNAPSHOT.zip and similar which is just some random version built on a developer desktop. This is not reliable.
Describe the solution you'd like
Replace with a dynamic maven dependency or build one on demand in CI.
Describe alternatives you've considered
This is what it takes to update this today.
Additional context
Part of #15, right now
integTest
is failing because of version incompatibility.The text was updated successfully, but these errors were encountered: