-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Changes in Snapshot Delete Flow for remote store interoperability. #7497
Add Changes in Snapshot Delete Flow for remote store interoperability. #7497
Conversation
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
48a79f3
to
18d5315
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3Repository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
18d5315
to
1668e10
Compare
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
4c32033
to
613d119
Compare
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
f333c05
to
b4f3892
Compare
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
b4f3892
to
ae291cc
Compare
Gradle Check (Jenkins) Run Completed with:
|
Please create a backlog item for ITs where deletion of lock files and .dat files fail . Rest LGTM . |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7497-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a430e18e82f7671e01c37ae5a549fc36dd673b1a
# Push it to GitHub
git push --set-upstream origin backport/backport-7497-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com> (cherry picked from commit a430e18)
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com> (cherry picked from commit a430e18)
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
…nteroperability. (#7497) (#8627) * Add Changes in Snapshot Delete Flow for remote store interoperability. (#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com> * Spotless fixes Signed-off-by: Sachin Kale <kalsac@amazon.com> --------- Signed-off-by: Bansi Kasundra <kasundra@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Bansi Kasundra <66969140+kasundra07@users.noreply.github.com> Co-authored-by: Sachin Kale <kalsac@amazon.com>
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
opensearch-project#7497) Signed-off-by: Bansi Kasundra <kasundra@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Changes in Delete Snapshot API required for Snapshot interoperability with Remote Store.
Related Issues
This change is dependent on Lock Manager changes and Create Snapshot API changes.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.