[Rename] Refactor o.e.watcher #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2021 13:48
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
|
✅ DCO Check Passed |
nknize
approved these changes
Mar 18, 2021
| * Other elasticsearch services can register their resource watchers with this service using {@link #add(ResourceWatcher)} | ||
| * method. This service will call {@link org.elasticsearch.watcher.ResourceWatcher#checkAndNotify()} method of all | ||
| * Other opensearch services can register their resource watchers with this service using {@link #add(ResourceWatcher)} | ||
| * method. This service will call {@link ResourceWatcher#checkAndNotify()} method of all |
There was a problem hiding this comment.
Suggested change
| * method. This service will call {@link ResourceWatcher#checkAndNotify()} method of all | |
| * method. This service will call {@link org.opensearch.watcher.ResourceWatcher#checkAndNotify()} method of all |
There was a problem hiding this comment.
Sure, added it back. I thought javadoc handles that automatically while publishing.
Adding FQCN for ResourceWatcher in javadoc Signed-off-by: Himanshu Setia <setiah@amazon.com>
|
✅ DCO Check Passed |
nknize
pushed a commit
that referenced
this pull request
Mar 20, 2021
This commit refactors the o.e.watcher package. References throughout the codebase are also refactored. Signed-off-by: Himanshu Setia <setiah@amazon.com>
nknize
pushed a commit
that referenced
this pull request
Mar 22, 2021
This commit refactors the o.e.watcher package. References throughout the codebase are also refactored. Signed-off-by: Himanshu Setia <setiah@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the o.e.watcher package to the o.opensearch namespace. All references throughout the codebase have also been refactored.
Signed-off-by: Himanshu Setia setiah@amazon.com