-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] Refactor o.e.watcher #399
Conversation
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
✅ DCO Check Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change needed otherwise LGTM!
* Other elasticsearch services can register their resource watchers with this service using {@link #add(ResourceWatcher)} | ||
* method. This service will call {@link org.elasticsearch.watcher.ResourceWatcher#checkAndNotify()} method of all | ||
* Other opensearch services can register their resource watchers with this service using {@link #add(ResourceWatcher)} | ||
* method. This service will call {@link ResourceWatcher#checkAndNotify()} method of all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* method. This service will call {@link ResourceWatcher#checkAndNotify()} method of all | |
* method. This service will call {@link org.opensearch.watcher.ResourceWatcher#checkAndNotify()} method of all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added it back. I thought javadoc handles that automatically while publishing.
Adding FQCN for ResourceWatcher in javadoc Signed-off-by: Himanshu Setia <setiah@amazon.com>
✅ DCO Check Passed |
This commit refactors the o.e.watcher package. References throughout the codebase are also refactored. Signed-off-by: Himanshu Setia <setiah@amazon.com>
This commit refactors the o.e.watcher package. References throughout the codebase are also refactored. Signed-off-by: Himanshu Setia <setiah@amazon.com>
This commit refactors the o.e.watcher package to the o.opensearch namespace. All references throughout the codebase have also been refactored.
Signed-off-by: Himanshu Setia setiah@amazon.com