Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rename] Refactor o.e.watcher package #286

Closed
wants to merge 2 commits into from
Closed

[Rename] Refactor o.e.watcher package #286

wants to merge 2 commits into from

Conversation

setiah
Copy link
Contributor

@setiah setiah commented Mar 12, 2021

Issue #160

[Rename] Refactor o.e.watcher package

Refactoring the org.elasticsearch.watcher package to org.opensearch.watcher
The watcher is used for reading ssl config changes in remote reindexing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Himanshu Setia setiah@amazon.com

Himanshu Setia added 2 commits March 11, 2021 20:24
[Rename] Refactor o.e.watcher package
15d6c26 
Refactoring the org.elasticsearch.watcher package to org.opensearch.watcher
The watcher is used for reading ssl config changes in remote reindexing
Removing redundant imports and whitespaces added by intellij
17382f5
tlfeng
tlfeng approved these changes Mar 12, 2021
View reviewed changes
server/src/main/java/org/opensearch/watcher/ResourceWatcherService.java
* Other elasticsearch services can register their resource watchers with this service using {@link #add(ResourceWatcher)}
* method. This service will call {@link org.elasticsearch.watcher.ResourceWatcher#checkAndNotify()} method of all
* Other opensearch services can register their resource watchers with this service using {@link #add(ResourceWatcher)}
* method. This service will call {@link ResourceWatcher#checkAndNotify()} method of all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: the full path of the class were removed unintentionally.

@odfe-release-bot
Copy link

Attention!
Request for admin to review the code before start one or more of these tests:

Type these trigger phrase to accept the tests:

  • start gradle check
  • start sample test1
  • start sample test2

Type this trigger phrase to add PR Creator to accept list:

  • add this user

@nknize nknize self-requested a review March 15, 2021 05:35
nknize
nknize requested changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watcher is licensed X-Pack and everything has been removed throughout the HLRC already. This is a dangling directory that needs to be removed. Can you do that in this PR and just change the name and description?

@odfe-release-bot
Copy link

❌   DCO Check Failed
Run ./dev-tools/signoff-check.sh remotes/origin/rename/opensearch 17382f514f51bf658089b6fbba8b980ba870f76b to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@setiah
Copy link
Contributor Author

setiah commented Mar 16, 2021

Watcher is licensed X-Pack and everything has been removed throughout the HLRC already. This is a dangling directory that needs to be removed. Can you do that in this PR and just change the name and description?

hey @nknize,
Thanks for checking. The x-pack licensed watcher is removed. The one i have moved here server/src/main/java/org/elasticsearch/watcher/ is under Apache 2.0 license. This is being used in remote reindexing to read ssl config changes from elasticsearch.yml file. reference
Let me know if my understanding here is wrong?

@nknize
Copy link
Collaborator

nknize commented Mar 16, 2021

Watcher is licensed X-Pack and everything has been removed throughout the HLRC already. This is a dangling directory that needs to be removed. Can you do that in this PR and just change the name and description?

^ My fault... I forgot that watcher is overloaded here... this is in regard to a File Watcher not the x-pack licensed feature. Disregard and /sftn

@nknize nknize self-requested a review March 16, 2021 18:45
@nknize nknize added >FORK Related to the fork process Rename Renaming to OpenSearch labels Mar 16, 2021
@setiah
Copy link
Contributor Author

setiah commented Mar 18, 2021

Closing this PR in favor of rebased on here - #399

@setiah setiah closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

@tlfeng tlfeng tlfeng approved these changes

Assignees
No one assigned
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@setiah @odfe-release-bot @nknize @tlfeng