-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] Refactor o.e.watcher package #286
Conversation
Refactoring the org.elasticsearch.watcher package to org.opensearch.watcher The watcher is used for reading ssl config changes in remote reindexing
* Other elasticsearch services can register their resource watchers with this service using {@link #add(ResourceWatcher)} | ||
* method. This service will call {@link org.elasticsearch.watcher.ResourceWatcher#checkAndNotify()} method of all | ||
* Other opensearch services can register their resource watchers with this service using {@link #add(ResourceWatcher)} | ||
* method. This service will call {@link ResourceWatcher#checkAndNotify()} method of all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: the full path of the class were removed unintentionally.
Attention! Type these trigger phrase to accept the tests:
Type this trigger phrase to add PR Creator to accept list:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watcher is licensed X-Pack and everything has been removed throughout the HLRC already. This is a dangling directory that needs to be removed. Can you do that in this PR and just change the name and description?
❌ DCO Check Failed |
hey @nknize, |
^ My fault... I forgot that |
Closing this PR in favor of rebased on here - #399 |
Issue #160
[Rename] Refactor o.e.watcher package
Refactoring the org.elasticsearch.watcher package to org.opensearch.watcher
The watcher is used for reading ssl config changes in remote reindexing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Signed-off-by: Himanshu Setia setiah@amazon.com