-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2.0.0-rc1 release notes #3044
Add 2.0.0-rc1 release notes #3044
Conversation
❌ Gradle Check failure c9f75a51d2d763ebc85cb3ab1ffe59dfc06cb88d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase from main to ensure passing tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out what opensearch-project/job-scheduler#172 looks like, I think I expected something like that here. |
c9f75a5
to
cde52c4
Compare
❌ Gradle Check failure cde52c43fecdb51d258ad0b04b469f866b15a09e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just keep the titles and make the GitHub issues clickable. Like in https://github.com/opensearch-project/job-scheduler/pull/172/files.
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
cde52c4
to
d8f1e62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! Do you think it's worth doing a pass on aligning language/standardizing things like [Remove] Xyz ...
, capitalizing consistently, etc.?
I don't think it's worth it since a lot of the titles would require a manual rewrite to ensure they're in the same format - not all of them start with action verbs or tags. But going forward definitely we should ensure all PRs have a check to ensure they're in the right format - referencing the discussion in #1868. |
Changes requested have been addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos for combing through all of the commits and crafting this!
Need to be merged in for release by eod
Signed-off-by: Poojita Raj <poojiraj@amazon.com> (cherry picked from commit 9da0a86)
Signed-off-by: Poojita Raj poojiraj@amazon.com
Description
Adding release notes for the 2.0 release. There was no common branch point to start the release notes from - so it started from commit f14e0a3 - the commit after #2489. Dependabot PRs have been removed for the sake of brevity.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.