Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2.0.0-rc1 release notes #3044

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

Poojita-Raj
Copy link
Contributor

Signed-off-by: Poojita Raj poojiraj@amazon.com

Description

Adding release notes for the 2.0 release. There was no common branch point to start the release notes from - so it started from commit f14e0a3 - the commit after #2489. Dependabot PRs have been removed for the sake of brevity.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Poojita-Raj Poojita-Raj requested review from a team and reta as code owners April 22, 2022 16:43
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c9f75a51d2d763ebc85cb3ab1ffe59dfc06cb88d
Log 4721

Reports 4721

nknize
nknize previously requested changes Apr 22, 2022
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase from main to ensure passing tests.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These notes need to be humanly readable. This isn't really. So I am afraid we need to hand-edit this entire file.

Screen Shot 2022-04-22 at 5 34 21 PM

@elfisher @bbarani can agree/disagree

@dblock
Copy link
Member

dblock commented Apr 22, 2022

Check out what opensearch-project/job-scheduler#172 looks like, I think I expected something like that here.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure cde52c43fecdb51d258ad0b04b469f866b15a09e
Log 4741

Reports 4741

dblock
dblock previously requested changes Apr 25, 2022
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just keep the titles and make the GitHub issues clickable. Like in https://github.com/opensearch-project/job-scheduler/pull/172/files.

release-notes/opensearch.release-notes-2.0.0-rc1.md Outdated Show resolved Hide resolved
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Do you think it's worth doing a pass on aligning language/standardizing things like [Remove] Xyz ..., capitalizing consistently, etc.?

@Poojita-Raj
Copy link
Contributor Author

Much better! Do you think it's worth doing a pass on aligning language/standardizing things like [Remove] Xyz ..., capitalizing consistently, etc.?

I don't think it's worth it since a lot of the titles would require a manual rewrite to ensure they're in the same format - not all of them start with action verbs or tags. But going forward definitely we should ensure all PRs have a check to ensure they're in the right format - referencing the discussion in #1868.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d8f1e62
Log 4814

Reports 4814

@Poojita-Raj Poojita-Raj requested a review from dblock April 26, 2022 21:24
@Poojita-Raj Poojita-Raj dismissed nknize’s stale review April 26, 2022 21:25

Changes requested have been addressed.

Copy link
Member

@kartg kartg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for combing through all of the commits and crafting this!

@Poojita-Raj Poojita-Raj dismissed dblock’s stale review April 27, 2022 01:13

Need to be merged in for release by eod

@Poojita-Raj Poojita-Raj merged commit 9da0a86 into opensearch-project:main Apr 27, 2022
@Poojita-Raj Poojita-Raj added the backport 2.0 Backport to 2.0 branch label Apr 27, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 27, 2022
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
(cherry picked from commit 9da0a86)
@tlfeng tlfeng added documentation Improvements or additions to documentation v2.0.0 Version 2.0.0 labels Apr 27, 2022
Poojita-Raj added a commit that referenced this pull request Apr 27, 2022
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
(cherry picked from commit 9da0a86)

Co-authored-by: Poojita Raj <poojiraj@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.0 Backport to 2.0 branch documentation Improvements or additions to documentation v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants