Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.3.0 release notes in main #2489

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

dreamer-89
Copy link
Member

Signed-off-by: Suraj Singh surajrider@gmail.com

Description

Adds 1.3 release notes starting from 1.x version bump to 1.3.

Issues Resolved

#2257

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89 dreamer-89 requested a review from a team as a code owner March 16, 2022 18:51
@dreamer-89 dreamer-89 requested a review from mch2 March 16, 2022 18:51
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 5c4318a334363d419b8d673882f30eb3d24506b2
Log 3454

Reports 3454

@dblock
Copy link
Member

dblock commented Mar 16, 2022

I understand these were generated with a tool, but they are unreadable because of the garbage in the commit messages. Should we do a human pass on those first? @stockholmux @elfisher ?

@stockholmux
Copy link
Member

Yeah, @dblock, these don't look right and are a major departure from our previous format.

@dreamer-89
Copy link
Member Author

dreamer-89 commented Mar 16, 2022

Yeah, @dblock, these don't look right and are a major departure from our previous format.

Thanks @stockholmux for the review. I was following the same steps as for 1.2.0 release to generate the md file using git-release-notes.

Can you please share previous format you are referring here ? I will try to follow the same.

@owaiskazi19
Copy link
Member

owaiskazi19 commented Mar 16, 2022

Yeah, @dblock, these don't look right and are a major departure from our previous format.

Thanks @stockholmux for the review. Can you please share previous format you are referring here ? I will try to follow the same.

Here are the release notes @dreamer-89 : https://github.com/opensearch-project/OpenSearch/tree/main/release-notes

@dreamer-89
Copy link
Member Author

dreamer-89 commented Mar 16, 2022

Yeah, @dblock, these don't look right and are a major departure from our previous format.

Thanks @stockholmux for the review. Can you please share previous format you are referring here ? I will try to follow the same.

Here are the release notes @dreamer-89 : https://github.com/opensearch-project/OpenSearch/tree/main/release-notes

Thank you @owaiskazi19 for sharing the sample.
The 1.3.0 generated release notes, look similar to one you shared. I noticed though there is a solid line (like below) from dependabot commits. I can remove this line from dependabot commits.


@dblock @stockholmux : What do you suggest ?

@stockholmux
Copy link
Member

So when I compare the release notes of 1.2.0 to these, I'm seeing a lot more that looks like it's generated by a machine - for example, a lot of 'bump' generated by dependabot and the autogenerated email accounts (e.g. 49699333+dependabot[bot]@users.noreply.github.com)

@dreamer-89
Copy link
Member Author

dreamer-89 commented Mar 16, 2022

So when I compare the release notes of 1.2.0 to these, I'm seeing a lot more that looks like it's generated by a machine - for example, a lot of 'bump' generated by dependabot and the autogenerated email accounts (e.g. 49699333+dependabot[bot]@users.noreply.github.com)

Thanks @stockholmux for the prompt response.

I see there was a recent change, on Feb 17th where we did dependabot integration in OpenSearch repository. Dependabot updates the new version of dependencies automatically and currently runs on weekly basis. If you feel these commits, don't add value in release notes, I can remove these.

@stockholmux
Copy link
Member

stockholmux commented Mar 16, 2022

@dreamer-89 I think that would go a long way. @dblock Thoughts?

@dblock
Copy link
Member

dblock commented Mar 17, 2022

@dreamer-89 I think that would go a long way. @dblock Thoughts?

Definitely. I would hand-edit the notes the be useful to humans as much as needed.

I also have #1868 opened that could be a solution to this problem moving forward.

@dreamer-89
Copy link
Member Author

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 69ed0bf6ce16fccd937727ff7b1e85facc8e5d36
Log 3492

Reports 3492

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 95b6151081f5e5264559ceabe6cedea8a9997033
Log 3493

Reports 3493

Signed-off-by: Suraj Singh <surajrider@gmail.com>
…n, linings, incorrect blocks

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure dd8f43c
Log 3494

Reports 3494

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure dd8f43c
Log 3495

Reports 3495

@dreamer-89
Copy link
Member Author

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=1C3D54BD19E7BE49 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sv-SE -Dtests.timezone=America/Indiana/Marengo -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([1C3D54BD19E7BE49:1B4B81762261C814]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success dd8f43c
Log 3498

Reports 3498

@dreamer-89 dreamer-89 merged commit f14e0a3 into opensearch-project:main Mar 17, 2022
@Poojita-Raj Poojita-Raj mentioned this pull request Apr 22, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants