Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change whitesource integration to scan on 1.x branch #1786

Merged

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Dec 21, 2021

Signed-off-by: Zelin Hao zelinhao@amazon.com

Description

Change the WhiteSource integration to do scan on 1.x branch. Ref: https://whitesource.atlassian.net/wiki/spaces/WD/pages/697696422/WhiteSource+for+GitHub.com#Scan-Settings-(scanSettings)

Please be aware that when this PR is merged, WhiteSource integration might be automatically created CVEs Github issues like these in build repo.

Core team can change "minSeverityLevel": "LOW" to select the minimum severity level of CVEs to be created. For example, if this parameter is changed to "MEDIUM", any low severity CVEs won't be created as issues. Ref: here

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh requested a review from a team as a code owner December 21, 2021 22:24
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d647362
Log 1613

Reports 1613

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zelinh Does this resolve issue #1593?

@zelinh
Copy link
Member Author

zelinh commented Dec 22, 2021

@zelinh Does this resolve issue #1593?

I don't think this will resolve that issue. I haven't heard from WhiteSource support regarding of the status of that issue for some time. We have been experiencing troubles using WhiteSource to scan the main branch of OpenSearch repo even with manual scan, but everything works now for 1.x. I am adding this parameter here to see how the integration works for 1.x branch since it was previously set for main branch.

@zelinh
Copy link
Member Author

zelinh commented Dec 29, 2021

After investigation with @peterzhuamazon , we found that WhiteSource spent really long time looking into the qa folder in OpenSearch that contains files all related to the previous version of ODFE. It will attempt to download all the deb/rpm/tar/jars for all the versions of ES from elastic repos and take around 3-6 hrs. Since scanning these is irrelevant to our OpenSearch and very time consuming, we will exclude them from the scan configuration (Line 148 in whitesource.config in my PR).

Hopefully this may resolve the issue with WhiteSource integration on OpenSearch repo.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success e485612
Log 1715

Reports 1715

@VachaShah VachaShah merged commit e67ba91 into opensearch-project:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants