Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] New Mend (formerly Whitesource) integration is not working correctly - autoclosed #1593

Closed
zelinh opened this issue Nov 19, 2021 · 12 comments · Fixed by #7177
Closed
Assignees
Labels
bug Something isn't working Mend: configuration error WhiteSource configuration error

Comments

@zelinh
Copy link
Member

zelinh commented Nov 19, 2021

Describe the bug

We previous installed a WhiteSource Github app for CVEs scan. However, it doesn't work correctly at this time. We just get informed from WhiteSource support that they are using Java 8 for their integration with Github.com. Although we currently began to support Java 11, it would still cause the gradle resolution failed.

To Reproduce
N/A

Expected behavior
A clear and concise description of what you expected to happen.

Plugins
WhiteSource integration with Github.com

@zelinh zelinh added bug Something isn't working untriaged labels Nov 19, 2021
@zelinh zelinh changed the title [BUG] new WhiteSource integration is not working correctly [BUG] New WhiteSource integration is not working correctly Nov 19, 2021
@dblock
Copy link
Member

dblock commented Nov 22, 2021

What is specifically failing when using Java 8?

@zelinh
Copy link
Member Author

zelinh commented Nov 23, 2021

What is specifically failing when using Java 8?

WhiteSource integration can't scan all libraries comprehensively currently. @bbarani and I are reaching out to WhiteSource support separately for this same issue. However, we got different respond from them. Barani was told that the issue is because of an unsupported Gradle version v6.6.1 which is necessary for our project build, while I was told it's related to java version. We are keeping contacting them and will also have another backup plan for CVEs scan on repos.

@VachaShah
Copy link
Collaborator

@zelinh One of the recent PRs #1603 had a successful WhiteSource run https://github.com/opensearch-project/OpenSearch/runs/4296697988. Was any fix done for this?

@zelinh
Copy link
Member Author

zelinh commented Nov 23, 2021

WhiteSource integration check on PR passes if there is no new vulnerability introduced in the PR. However, the general CVEs scan with WhiteSource integration in this repo is not working correctly and not showing the right number of libraries. There might be package manager version issue on WhiteSource side. We are escalating this issue with WhiteSource support and waiting for them to help us.

@zelinh
Copy link
Member Author

zelinh commented Nov 24, 2021

I just got notice from WhiteSource team after their team review; it turned out to be a part of a bigger problem with how they manage versions of all the scanners in WhiteSource integration. They had an epic ticket for this and will keep us updated with the progress.

@VachaShah
Copy link
Collaborator

Thank you for the update @zelinh ! Since the WhiteSource is failing and not scanning correctly, can we disable it till we have a fix so that PRs like #1594 are not blocked?

@zelinh
Copy link
Member Author

zelinh commented Nov 24, 2021

I think we can disregard the WhiteSource check for now and keep merging PRs. I don't have access to disable it. Any objections? @bbarani @dblock

@VachaShah
Copy link
Collaborator

@zelinh The Whitesource job on 1.x fails after 375m. Is there any update here?

@zelinh
Copy link
Member Author

zelinh commented Feb 24, 2022

Unfortunately no, I had a meeting with WhiteSource support last Monday regarding of the issue on scanning our core repo and she said she would escalate this issue but I haven't heard any update from them since then.
I think for now, one option is that we ignore the WhiteSource PR check for core repo now;
or the other option is to change this to be success so the check will always be success no matter it passes or fails. Ref: https://whitesource.atlassian.net/wiki/spaces/WD/pages/697696422/WhiteSource+for+GitHub.com#Check-Run-Settings-(checkRunSettings)

@CEHENKLE
Copy link
Member

CEHENKLE commented Mar 3, 2022

Until this gets fixed, let's disable the whitesource integration. Otherwise this is blocking our ability to build on 1.3

@peterzhuamazon peterzhuamazon self-assigned this Apr 15, 2023
@peterzhuamazon peterzhuamazon added the Mend: configuration error WhiteSource configuration error label Apr 15, 2023
@peterzhuamazon peterzhuamazon changed the title [BUG] New WhiteSource integration is not working correctly [BUG] New Mend (formerly Whitesource) integration is not working correctly Apr 15, 2023
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Apr 15, 2023

We will remove the mend scan config now, to resolve this temporarily and would look into re-adding it later on.
cc: @bbarani

@mend-for-github-com
Copy link
Contributor

✔️ This issue was automatically closed by Mend because the errors have been resolved.

@mend-for-github-com mend-for-github-com bot changed the title [BUG] New Mend (formerly Whitesource) integration is not working correctly [BUG] New Mend (formerly Whitesource) integration is not working correctly - autoclosed Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Mend: configuration error WhiteSource configuration error
Projects
Development

Successfully merging a pull request may close this issue.

6 participants