Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] SnapshotInfo pinned timestamp version change to V_2_17_0 (#15616) #15619

Merged

Conversation

anshu1106
Copy link
Contributor

Signed-off-by: Anshu Agarwal anshukag@amazon.com
Co-authored-by: Anshu Agarwal anshukag@amazon.com
(cherry picked from commit c62626d)

Description

Backport for #15616

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…project#15616)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
(cherry picked from commit c62626d)
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 2247d71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for 2247d71: SUCCESS

@sachinpkale sachinpkale merged commit 9ba4c53 into opensearch-project:2.x Sep 3, 2024
58 of 60 checks passed
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.69%. Comparing base (c8bed7c) to head (2247d71).
Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
...in/java/org/opensearch/snapshots/SnapshotInfo.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15619      +/-   ##
============================================
+ Coverage     71.63%   71.69%   +0.06%     
- Complexity    63961    63981      +20     
============================================
  Files          5243     5243              
  Lines        299170   299321     +151     
  Branches      43548    43569      +21     
============================================
+ Hits         214297   214589     +292     
+ Misses        66912    66741     -171     
- Partials      17961    17991      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants