Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SnapshotV2] SnapshotInfo pinned timestamp version change to V_2_17_0 #15616

Conversation

anshu1106
Copy link
Contributor

Description

This PR changes SnapshotInfo pinned timestamp version to V_2_17_0 for ser/der. The SnapshotInfo changes were introduced in #15124

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for 8bbb6db: SUCCESS

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.82%. Comparing base (7a9cb35) to head (8bbb6db).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/org/opensearch/snapshots/SnapshotInfo.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15616      +/-   ##
============================================
- Coverage     71.83%   71.82%   -0.01%     
- Complexity    63932    63961      +29     
============================================
  Files          5258     5258              
  Lines        299329   299354      +25     
  Branches      43259    43261       +2     
============================================
+ Hits         215010   215011       +1     
- Misses        66587    66621      +34     
+ Partials      17732    17722      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit c62626d into opensearch-project:main Sep 3, 2024
59 of 62 checks passed
@anshu1106 anshu1106 added the backport 2.x Backport to 2.x branch label Sep 3, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15616-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c62626d25430bea94123d6176caef56ae94deb3f
# Push it to GitHub
git push --set-upstream origin backport/backport-15616-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15616-to-2.x.

anshu1106 added a commit to anshu1106/OpenSearch that referenced this pull request Sep 3, 2024
…project#15616)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
(cherry picked from commit c62626d)
sachinpkale pushed a commit that referenced this pull request Sep 3, 2024
…5619)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
(cherry picked from commit c62626d)
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
…project#15616)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants