Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add support for wildcard field type (#13461) #14167

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Jun 11, 2024

Description

This adds support for the "wildcard" field type that supports efficient execution of wildcard, prefix, and regexp queries by matching first against trigrams (or bigrams or individual characters), then post-filtering by evaluating the original field value against the pattern.

Manual backport of #13461

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This adds support for the "wildcard" field type that supports efficient
execution of wildcard, prefix, and regexp queries by matching first against
trigrams (or bigrams or individual characters), then post-filtering by
evaluating the original field value against the pattern.

---------

Signed-off-by: Michael Froh <froh@amazon.com>
(cherry picked from commit b71e547)
Copy link
Contributor

❌ Gradle check result for 8067a31: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8067a31: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8067a31: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 8067a31: SUCCESS

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 74.57627% with 90 lines in your changes missing coverage. Please review.

Project coverage is 71.40%. Comparing base (0dd892c) to head (8067a31).
Report is 348 commits behind head on 2.x.

Files Patch % Lines
...g/opensearch/index/mapper/WildcardFieldMapper.java 74.50% 65 Missing and 25 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14167      +/-   ##
============================================
+ Coverage     71.28%   71.40%   +0.12%     
- Complexity    60145    61614    +1469     
============================================
  Files          4957     5054      +97     
  Lines        282799   289680    +6881     
  Branches      41409    42314     +905     
============================================
+ Hits         201591   206857    +5266     
- Misses        64189    65382    +1193     
- Partials      17019    17441     +422     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 7e6f0d5 into opensearch-project:2.x Jun 11, 2024
51 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…earch-project#14167)

This adds support for the "wildcard" field type that supports efficient
execution of wildcard, prefix, and regexp queries by matching first against
trigrams (or bigrams or individual characters), then post-filtering by
evaluating the original field value against the pattern.

---------

Signed-off-by: Michael Froh <froh@amazon.com>
(cherry picked from commit b71e547)
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants