Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wildcard field type #13461

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Apr 30, 2024

Description

This adds support for the "wildcard" field type that supports efficient execution of wildcard, prefix, and regexp queries by matching first against trigrams (or bigrams or individual characters), then post-filtering by evaluating the original field value against the pattern.

Related Issues

Resolves #5639

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request feature New feature or request help wanted Extra attention is needed Indexing Indexing, Bulk Indexing and anything related to indexing Search Search query, autocomplete ...etc Search:Query Capabilities labels Apr 30, 2024
Copy link
Contributor

❌ Gradle check result for 3bd8f40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi harshavamsi added the v2.15.0 Issues and PRs related to version 2.15.0 label May 2, 2024
@msfroh
Copy link
Collaborator Author

msfroh commented May 22, 2024

Incidentally, I think I can improve the situation for regex queries by applying the logic described in https://swtch.com/~rsc/regexp/regexp4.html

Copy link
Contributor

❌ Gradle check result for f47573d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5412e3e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f1c74d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for a44d9e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@msfroh msfroh added the backport 2.x Backport to 2.x branch label May 30, 2024
@msfroh msfroh marked this pull request as ready for review May 30, 2024 06:20
@msfroh
Copy link
Collaborator Author

msfroh commented Jun 11, 2024

Flaky test failure: #12675

Copy link
Contributor

✅ Gradle check result for aa62135: SUCCESS

@msfroh msfroh merged commit b71e547 into opensearch-project:main Jun 11, 2024
30 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13461-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b71e547e938876c2cec9fcc0328ffbd6b4a50db6
# Push it to GitHub
git push --set-upstream origin backport/backport-13461-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13461-to-2.x.

msfroh added a commit to msfroh/OpenSearch that referenced this pull request Jun 11, 2024
This adds support for the "wildcard" field type that supports efficient
execution of wildcard, prefix, and regexp queries by matching first against
trigrams (or bigrams or individual characters), then post-filtering by
evaluating the original field value against the pattern.

---------

Signed-off-by: Michael Froh <froh@amazon.com>
(cherry picked from commit b71e547)
@msfroh
Copy link
Collaborator Author

msfroh commented Jun 11, 2024

Backport PR: #14167

reta pushed a commit that referenced this pull request Jun 11, 2024
This adds support for the "wildcard" field type that supports efficient
execution of wildcard, prefix, and regexp queries by matching first against
trigrams (or bigrams or individual characters), then post-filtering by
evaluating the original field value against the pattern.

---------

Signed-off-by: Michael Froh <froh@amazon.com>
(cherry picked from commit b71e547)
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…earch-project#14167)

This adds support for the "wildcard" field type that supports efficient
execution of wildcard, prefix, and regexp queries by matching first against
trigrams (or bigrams or individual characters), then post-filtering by
evaluating the original field value against the pattern.

---------

Signed-off-by: Michael Froh <froh@amazon.com>
(cherry picked from commit b71e547)
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
This adds support for the "wildcard" field type that supports efficient
execution of wildcard, prefix, and regexp queries by matching first against
trigrams (or bigrams or individual characters), then post-filtering by
evaluating the original field value against the pattern.

---------

Signed-off-by: Michael Froh <froh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request feature New feature or request help wanted Extra attention is needed Indexing Indexing, Bulk Indexing and anything related to indexing Search:Query Capabilities Search Search query, autocomplete ...etc v2.15.0 Issues and PRs related to version 2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for wildcard field type
6 participants