[Workspace] Refactor: update change access modal display name #8680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
opensearch-changeset-bot bot
added a commit
to raintygao/OpenSearch-Dashboards
that referenced
this pull request
Oct 22, 2024
Signed-off-by: tygao <tygao@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8680 +/- ##
==========================================
- Coverage 60.85% 60.85% -0.01%
==========================================
Files 3793 3793
Lines 90393 90393
Branches 14189 14189
==========================================
- Hits 55008 55006 -2
- Misses 31907 31908 +1
- Partials 3478 3479 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Oct 23, 2024
SuZhou-Joe
approved these changes
Oct 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
* refactor: update change access modal display name Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #8680 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 53e8404) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Oct 29, 2024
…#8732) * refactor: update change access modal display name --------- (cherry picked from commit 53e8404) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…arch-project#8680) * refactor: update change access modal display name Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#8680 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update change access modal display name from access level value to access level name
Screenshot
Before
After
Testing the changes
Go to workspace collaborators page.
Changelog
Check List
yarn test:jestyarn test:jest_integration