Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Fix config related issues and dedup the category in landing page #8160

Merged

Conversation

raintygao
Copy link
Contributor

@raintygao raintygao commented Sep 12, 2024

Description

This PR is to fix:

  • Do not automatically append workspaces when creating config saved objects.
  • Find global configs when upgrading advanced settings config.
  • Dedup the category in landing page by comparing the category.id instead of the reference of the category object.

Issues Resolved

Screenshot

Do not automatically append workspaces when creating config saved objects. - Before fix

20240912172011048.mp4

Do not automatically append workspaces when creating config saved objects. - After fix

20240912172203710.mp4

Find global configs when upgrading advanced settings config.

20240912171413721.mp4

Dedup category in landing page

image

Testing the changes

Changelog

  • fix: Config related issues
  • fix: Dedup the category

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.90%. Comparing base (84b3cf0) to head (c00fbb4).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...ver/saved_objects/workspace_id_consumer_wrapper.ts 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8160   +/-   ##
=======================================
  Coverage   63.89%   63.90%           
=======================================
  Files        3739     3739           
  Lines       88752    88762   +10     
  Branches    13810    13814    +4     
=======================================
+ Hits        56712    56720    +8     
  Misses      31444    31444           
- Partials      596      598    +2     
Flag Coverage Δ
Linux_1 29.96% <80.00%> (+<0.01%) ⬆️
Linux_2 58.79% <ø> (ø)
Linux_3 40.25% <ø> (ø)
Linux_4 31.36% <100.00%> (ø)
Windows_1 29.97% <80.00%> (+<0.01%) ⬆️
Windows_2 58.74% <ø> (ø)
Windows_3 40.25% <ø> (ø)
Windows_4 31.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Copy link
Contributor

❌ Entry Too Long

Entry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

@github-actions github-actions bot added failed changeset and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Sep 12, 2024
Copy link
Contributor

❌ Entry Too Long

Entry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

2 similar comments
Copy link
Contributor

❌ Entry Too Long

Entry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

Copy link
Contributor

❌ Entry Too Long

Entry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

@SuZhou-Joe SuZhou-Joe changed the title fix: do not automatically append workspaces params when creating config [workspace] Fix config related issues and dedup the category in landing page Sep 12, 2024
Copy link
Contributor

❌ Entry Too Long

Entry is 113 characters long, which is 13 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

@SuZhou-Joe SuZhou-Joe merged commit 07c7fa1 into opensearch-project:main Sep 12, 2024
75 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2024
…ng page (#8160)

* fix: do not automatically append workspaces params when creating config

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: find global configs when upgrade config

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: dedup category in landing page

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #8160 created/updated

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 07c7fa1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2024
…ng page (#8160)

* fix: do not automatically append workspaces params when creating config

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: find global configs when upgrade config

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: dedup category in landing page

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #8160 created/updated

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 07c7fa1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 12, 2024
…ng page (#8160) (#8162)

* fix: do not automatically append workspaces params when creating config



* fix: find global configs when upgrade config



* feat: dedup category in landing page



* Changeset file for PR #8160 created/updated

---------




(cherry picked from commit 07c7fa1)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe added a commit that referenced this pull request Sep 12, 2024
…ng page (#8160) (#8163)

* fix: do not automatically append workspaces params when creating config



* fix: find global configs when upgrade config



* feat: dedup category in landing page



* Changeset file for PR #8160 created/updated

---------




(cherry picked from commit 07c7fa1)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants