Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navigation] Fit and finish issues collective for left nav and landing page #8140

Closed
wants to merge 21 commits into from
Closed

[navigation] Fit and finish issues collective for left nav and landing page #8140

wants to merge 21 commits into from

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Sep 11, 2024 •
edited
Loading

Description

  • Make card in landing page with max width of 240px
  • Inherit color from workspace settings in left nav.
  • Look and feel update to left nav

Issues Resolved

Screenshot

Inherit color from workspace settings in left nav.

image

Typography (observability title)

image

Testing the changes

Changelog

  • feat: [navigation] Adjust the appearances of the left navigation menu and the landing page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 11, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#8140 created/updated
aec9681
ruanyl
ruanyl reviewed Sep 20, 2024
View reviewed changes
src/plugins/management/public/components/feature_cards/feature_cards.tsx Outdated Show resolved Hide resolved
src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss Outdated Show resolved Hide resolved
src/core/public/chrome/ui/header/collapsible_nav_groups.tsx Outdated
@@ -58,7 +58,11 @@ export function NavGroups({

return {
id: `${link.id}-${link.title}`,
name: <EuiText size="xs">{link.title}</EuiText>,
name: (
<EuiText size="xs" style={{ fontSize: '14px', lineHeight: '16px', fontWeight: 400 }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we not use custom font size?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, removed.

@SuZhou-Joe SuZhou-Joe added 2.17.1 and removed v2.18.0 labels Sep 23, 2024
ruanyl
ruanyl previously approved these changes Sep 24, 2024
View reviewed changes
SuZhou-Joe and others added 19 commits September 26, 2024 13:26
@SuZhou-Joe
fix: fix width
9b9d98e 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: use workspace color
638c902 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@opensearch-changeset-bot @SuZhou-Joe
Changeset file for PR opensearch-project#8140 created/updated
c70d8a9
@SuZhou-Joe
feat: style fit and finish for left nav
57fe9a4 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@opensearch-changeset-bot @SuZhou-Joe
Changeset file for PR opensearch-project#8140 created/updated
5d12a8f
@SuZhou-Joe
feat: update code
901a4f1 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update style
8219107 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update padding
1da3a34 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update
b74973a 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update
b038054 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update style
5650359 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update
24b913b 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update
bc62ba0 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update style
14e96bd 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update
e83f647 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update snapshot
f8219c1 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update
8b5186b 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: revert the customized style on nested items
9a8bc17 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update mobile break points
b1ccd5c 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
fix: snapshot
7d9aa81 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: optimize style
43d47b4 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
Copy link
Member Author

Close for #8332

@SuZhou-Joe SuZhou-Joe closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki left review comments

@ruanyl ruanyl ruanyl left review comments

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 backport 2.x distinguished-contributor navigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuZhou-Joe @AMoo-Miki @ruanyl