Discover Bug Fixes

[LDrago27]

Description

This changes fixes the following bugs

• SQL Search not working for IndexPatterns with Wildcards in the name
• Intial Page Load was not working for Non DQL default language

Issues Resolved

Screenshot

Meeting.Recording.-.Sahoo.Suchit.Instant.Meeting.6.mp4

Testing the changes

Changelog

• skip

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

[codecov]

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (0245540) to head (a8cb534).
Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
.../public/query/query_string/query_string_manager.ts	45.45%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7948      +/-   ##
==========================================
- Coverage   60.97%   60.97%   -0.01%     
==========================================
  Files        3684     3684              
  Lines       87038    87047       +9     
  Branches    13376    13378       +2     
==========================================
+ Hits        53074    53078       +4     
- Misses      30750    30754       +4     
- Partials     3214     3215       +1     

Flag	Coverage Δ
Linux_1	29.26% <0.00%> (-0.01%)	⬇️
Linux_2	56.19% <ø> (ø)
Linux_3	37.82% <45.45%> (+<0.01%)	⬆️
Linux_4	29.56% <0.00%> (-0.01%)	⬇️
Windows_1	29.28% <0.00%> (-0.01%)	⬇️
Windows_2	56.14% <ø> (ø)
Windows_3	37.83% <45.45%> (+<0.01%)	⬆️
Windows_4	29.56% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sejli]

LGTM. Thanks for helping to fix these bugs!

[sejli]

Is there a reason why we removed the rest of the query object? I don't remember if the fetch() function for PPL and SQL use the rest of the object off the top of my head.

[LDrago27]

Before this change the request body that we used to send was of the following format

{
    query: {
      query: 'SELECT * FROM aaa* LIMIT 10',
      language: 'SQL',
      dataset: [Object],
      format: 'jdbc'
    },
    aggConfig: null,
    df: null
}

However the SQL plugins request only needs the following parameters.

Also we observed sending in the extra unrecognized parameters was causing bugs where the SQL Search not working for IndexPatterns with Wildcards in the name, therefore this PR aims to cleanup the request body that we send.

[kavilla]

yeah end up doing something similar here too https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7943/files