Skip to content

Commit

Permalink
Fix Discover intial pageload for non DQL language
Browse files Browse the repository at this point in the history
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
  • Loading branch information
LDrago27 committed Aug 31, 2024
1 parent 26df213 commit a8cb534
Showing 1 changed file with 25 additions and 7 deletions.
32 changes: 25 additions & 7 deletions src/plugins/data/public/query/query_string/query_string_manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,32 @@ export class QueryStringManager {
}

public getDefaultQuery() {
return {
query: this.getDefaultQueryString(),
language: this.getDefaultLanguage(),
...(this.uiSettings &&
this.uiSettings.get(UI_SETTINGS.QUERY_ENHANCEMENTS_ENABLED) && {
dataset: this.datasetService?.getDefault(),
}),
const defaultLanguageId = this.getDefaultLanguage();
const defaultQuery = this.getDefaultQueryString();
const defaultDataset = this.datasetService?.getDefault();

const query = {
query: defaultQuery,
language: defaultLanguageId,
};

if (
this.uiSettings &&
this.uiSettings.get(UI_SETTINGS.QUERY_ENHANCEMENTS_ENABLED) &&
defaultDataset &&
this.languageService
) {
const language = this.languageService.getLanguage(defaultLanguageId);
const newQuery = { ...query, dataset: defaultDataset };

Check warning on line 79 in src/plugins/data/public/query/query_string/query_string_manager.ts

View check run for this annotation

Codecov / codecov/patch

src/plugins/data/public/query/query_string/query_string_manager.ts#L78-L79

Added lines #L78 - L79 were not covered by tests
const newQueryString = language?.getQueryString(newQuery) || '';

return {

Check warning on line 82 in src/plugins/data/public/query/query_string/query_string_manager.ts

View check run for this annotation

Codecov / codecov/patch

src/plugins/data/public/query/query_string/query_string_manager.ts#L82

Added line #L82 was not covered by tests
...newQuery,
query: newQueryString,
};
}

return query;
}

public formatQuery(query: Query | string | undefined): Query {
Expand Down

0 comments on commit a8cb534

Please sign in to comment.