Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multiple Datasource] Handle form values(request payload) if the selected type is available in the authentication registry. #6049

Merged
merged 12 commits into from
Mar 8, 2024

Addressing comments

a93ac4b
Select commit
Loading
Failed to load commit list.
Merged

[Multiple Datasource] Handle form values(request payload) if the selected type is available in the authentication registry. #6049

Addressing comments
a93ac4b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 8, 2024 in 0s

67.11% (+0.01%) compared to 9f3a689

View this Pull Request on Codecov

67.11% (+0.01%) compared to 9f3a689

Details

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 67.11%. Comparing base (9f3a689) to head (a93ac4b).

Files Patch % Lines
...omponents/validation/datasource_form_validation.ts 50.00% 1 Missing and 4 partials ⚠️
...components/create_form/create_data_source_form.tsx 75.00% 0 Missing and 2 partials ⚠️
...rce/components/edit_form/edit_data_source_form.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6049      +/-   ##
==========================================
+ Coverage   67.09%   67.11%   +0.01%     
==========================================
  Files        3322     3322              
  Lines       64238    64258      +20     
  Branches    10321    10329       +8     
==========================================
+ Hits        43101    43126      +25     
+ Misses      18621    18610      -11     
- Partials     2516     2522       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov