Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource] Remove experimental banner & badge #3755

Merged

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Mar 31, 2023

Description

[Multiple Datasource] Remove experimental banner
image
image

Issues Resolved

#3579

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Su <szhongna@amazon.com>
@zhongnansu zhongnansu requested a review from a team as a code owner March 31, 2023 09:12
@zhongnansu zhongnansu linked an issue Mar 31, 2023 that may be closed by this pull request
2 tasks
seanneumann
seanneumann previously approved these changes Mar 31, 2023
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristenTian
Copy link
Contributor

LGTM

kristenTian
kristenTian previously approved these changes Mar 31, 2023
@zhongnansu zhongnansu added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Mar 31, 2023
…ashboardsSection registration

Signed-off-by: Su <szhongna@amazon.com>
@zhongnansu zhongnansu dismissed stale reviews from kristenTian and seanneumann via e982e19 March 31, 2023 19:29
@zhongnansu
Copy link
Member Author

update with another commit to remove the "Experimental" badge

@zhongnansu zhongnansu changed the title [Multiple Datasource] Remove experimental banner [Multiple Datasource] Remove experimental banner & badge Mar 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #3755 (69fd066) into main (2db2c43) will decrease coverage by 0.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3755      +/-   ##
==========================================
- Coverage   66.43%   66.38%   -0.06%     
==========================================
  Files        3210     3209       -1     
  Lines       61677    61674       -3     
  Branches     9522     9521       -1     
==========================================
- Hits        40977    40942      -35     
- Misses      18419    18446      +27     
- Partials     2281     2286       +5     
Flag Coverage Δ
Linux 66.38% <ø> (+<0.01%) ⬆️
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dex_pattern_wizard/create_index_pattern_wizard.tsx 67.08% <ø> (+0.83%) ⬆️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhongnansu zhongnansu merged commit ce5c8cc into opensearch-project:main Apr 5, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2023
* [Multiple Datasource] Remove experimental banner
* Remove experimental badge from DataSourceManagementPlugin opensearchDashboardsSection registration

Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
(cherry picked from commit ce5c8cc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu pushed a commit that referenced this pull request Apr 6, 2023
* [Multiple Datasource] Remove experimental banner
* Remove experimental badge from DataSourceManagementPlugin opensearchDashboardsSection registration



(cherry picked from commit ce5c8cc)

Signed-off-by: Su <szhongna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
…project#3755)

* [Multiple Datasource] Remove experimental banner
* Remove experimental badge from DataSourceManagementPlugin opensearchDashboardsSection registration

Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multiple Datasource]Remove experiment feature banner.
5 participants