Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Multiple Datasource]Remove experiment feature banner. #3579

Closed
1 of 2 tasks
Tracked by #3577
zhongnansu opened this issue Mar 9, 2023 · 4 comments · Fixed by #3755
Closed
1 of 2 tasks
Tracked by #3577

[Multiple Datasource]Remove experiment feature banner. #3579

zhongnansu opened this issue Mar 9, 2023 · 4 comments · Fixed by #3755
Labels
multiple datasource multiple datasource project question Further information is requested v2.7.0

Comments

@zhongnansu
Copy link
Member

zhongnansu commented Mar 9, 2023 •
edited
Loading

  • Remove experiment feature banner
    image

  • Currently to enable the feature, user needs to set data_source.enabled: false to data_source.enabled: true and save the opensearch-dashboards.yml -> restart opensearch dashboards. reference] Wonder if in GA, we should turn it on by default @ahopp @zengyan-amazon @seraphjiang
@zhongnansu zhongnansu mentioned this issue Mar 9, 2023
Closed
9 tasks
@zhongnansu zhongnansu added multiple datasource multiple datasource project v2.7.0 ux / ui Improvements or additions to user experience, flows, components, UI elements and removed untriaged labels Mar 9, 2023
@zhongnansu zhongnansu changed the title Turn on multiple datasource feature by default [Multiple Datasource]Turn on feature switch by default in configuration Mar 9, 2023
@zhongnansu zhongnansu added question Further information is requested and removed ux / ui Improvements or additions to user experience, flows, components, UI elements labels Mar 9, 2023
@kavilla
Copy link
Member

kavilla commented Mar 10, 2023

Tagging @dagneyb as well.

@zhongnansu zhongnansu changed the title [Multiple Datasource]Turn on feature switch by default in configuration [Multiple Datasource]Removed experiment feature banner. Turn on feature switch by default in configuration yml Mar 14, 2023
@zhongnansu zhongnansu changed the title [Multiple Datasource]Removed experiment feature banner. Turn on feature switch by default in configuration yml [Multiple Datasource]Remove experiment feature banner. Turn on feature switch by default in configuration yml Mar 14, 2023
@zhongnansu
Copy link
Member Author

cc @ahopp

@ahopp
Copy link
Contributor

ahopp commented Mar 21, 2023

I'm aligned with this change - I say ship it.

@seraphjiang
Copy link
Member

we should turn it on by default

after GA, it should still disable by default. we don't want to impact existing customer behavior in setup/upgrade.

we might consider enable by default after 3.0

@zhongnansu zhongnansu changed the title [Multiple Datasource]Remove experiment feature banner. Turn on feature switch by default in configuration yml [Multiple Datasource]Remove experiment feature banner. Mar 24, 2023
@zhongnansu zhongnansu mentioned this issue Mar 31, 2023
Merged
8 tasks
@zhongnansu zhongnansu linked a pull request Mar 31, 2023 that will close this issue
[Multiple Datasource] Remove experimental banner & badge #3755
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
multiple datasource multiple datasource project question Further information is requested v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Multiple Datasource] Remove experimental banner & badge zhongnansu/OpenSearch-Dashboards
4 participants
@seraphjiang @ahopp @kavilla @zhongnansu