Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve capitalisation in some cases, correct typos in English, add translation for menu.new #307

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Improve capitalisation in some cases, correct typos in English, add translation for menu.new #307

merged 2 commits into from
Sep 13, 2021

Conversation

danyill
Copy link
Collaborator

@danyill danyill commented Sep 12, 2021

Closes #306

@JakobVogelsang
Copy link
Collaborator

Thank you for that PR! We all are very happy to see more and more contributors to OpenSCD. 👍
Your PR looks good for me. There are failing tests still and I can not merge it as is - which by the way should not happen, and we are looking at it #271 - still I would like to ask you to generate new snapshots:

1.) Delete the snapshot folders in your repo
2.) Execute npm run test. This will automatically generate new snapshots when there is a difference.

@JakobVogelsang JakobVogelsang added the Kind: Bug Something isn't working label Sep 13, 2021
@danyill
Copy link
Collaborator Author

danyill commented Sep 13, 2021

Thank you, snapshots updated.

JakobVogelsang
JakobVogelsang approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@JakobVogelsang JakobVogelsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much!

@JakobVogelsang JakobVogelsang merged commit b5e2621 into openscd:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobVogelsang JakobVogelsang JakobVogelsang approved these changes

Assignees
No one assigned
Labels
Kind: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

English typos/missing strings
2 participants
@danyill @JakobVogelsang