fix(translation): improve capitalization add missing menu.new (#307)

* Improve capitalization in some cases, correct typos in English, add translation for menu.new, closes #306 * Update snapshots
openscd · Sep 13, 2021 · b5e2621 · b5e2621
1 parent 58bebc9
commit b5e2621
Show file tree

Hide file tree

Showing 6 changed files with 97 additions and 27 deletions.
diff --git a/__snapshots__/BDA wizarding editing integration.md b/__snapshots__/BDA wizarding editing integration.md
@@ -2,12 +2,21 @@
 
 ## `defines a editBDaWizard to edit an existing BDA`
 
-#### `looks like the latest snapshot`
+####   `looks like the latest snapshot`
 
 ```html
-<mwc-dialog defaultaction="close" heading="Edit BDA" open="">
+<mwc-dialog
+  defaultaction="close"
+  heading="Edit BDA"
+  open=""
+>
   <div id="wizard-content">
-    <mwc-button fullwidth="" icon="delete" label="Remove" trailingicon="">
+    <mwc-button
+      fullwidth=""
+      icon="delete"
+      label="Remove"
+      trailingicon=""
+    >
     </mwc-button>
     <wizard-textfield
       dialoginitialfocus=""
@@ -352,7 +361,11 @@
         EntryID
       </mwc-list-item>
     </wizard-select>
-    <wizard-select fixedmenuposition="" helper="Type" label="type">
+    <wizard-select
+      fixedmenuposition=""
+      helper="Type"
+      label="type"
+    >
       <mwc-list-item
         aria-disabled="true"
         class="Struct"
@@ -537,7 +550,12 @@
         false
       </mwc-list-item>
     </wizard-select>
-    <wizard-select disabled="" helper="Default value" label="Val" nullable="">
+    <wizard-select
+      disabled=""
+      helper="Default value"
+      label="Val"
+      nullable=""
+    >
       <mwc-list-item
         aria-disabled="false"
         aria-selected="false"
@@ -614,14 +632,19 @@
   >
   </mwc-button>
 </mwc-dialog>
+
 ```
 
 ## `defines a createBDaWizard to create a new BDA element`
 
-#### `looks like the latest snapshot`
+####   `looks like the latest snapshot`
 
 ```html
-<mwc-dialog defaultaction="close" heading="Edit BDA" open="">
+<mwc-dialog
+  defaultaction="close"
+  heading="Edit BDA"
+  open=""
+>
   <div id="wizard-content">
     <wizard-textfield
       dialoginitialfocus=""
@@ -963,7 +986,11 @@
         EntryID
       </mwc-list-item>
     </wizard-select>
-    <wizard-select fixedmenuposition="" helper="Type" label="type">
+    <wizard-select
+      fixedmenuposition=""
+      helper="Type"
+      label="type"
+    >
       <mwc-list-item
         aria-disabled="false"
         class="Struct"
@@ -1135,7 +1162,12 @@
         false
       </mwc-list-item>
     </wizard-select>
-    <wizard-select disabled="" helper="Default value" label="Val" nullable="">
+    <wizard-select
+      disabled=""
+      helper="Default value"
+      label="Val"
+      nullable=""
+    >
     </wizard-select>
     <wizard-textfield
       disabled=""
@@ -1161,4 +1193,6 @@
   >
   </mwc-button>
 </mwc-dialog>
+
 ```
+
diff --git a/__snapshots__/DA wizarding editing integration.md b/__snapshots__/DA wizarding editing integration.md
@@ -2,12 +2,21 @@
 
 ## `defines a editDaWizard to edit an existing DA`
 
-#### `looks like the latest snapshot`
+####   `looks like the latest snapshot`
 
 ```html
-<mwc-dialog defaultaction="close" heading="Edit DA" open="">
+<mwc-dialog
+  defaultaction="close"
+  heading="Edit DA"
+  open=""
+>
   <div id="wizard-content">
-    <mwc-button fullwidth="" icon="delete" label="Remove" trailingicon="">
+    <mwc-button
+      fullwidth=""
+      icon="delete"
+      label="Remove"
+      trailingicon=""
+    >
     </mwc-button>
     <wizard-textfield
       dialoginitialfocus=""
@@ -352,7 +361,11 @@
         EntryID
       </mwc-list-item>
     </wizard-select>
-    <wizard-select fixedmenuposition="" helper="Type" label="type">
+    <wizard-select
+      fixedmenuposition=""
+      helper="Type"
+      label="type"
+    >
       <mwc-list-item
         aria-disabled="true"
         class="Struct"
@@ -581,7 +594,12 @@
         false
       </mwc-list-item>
     </wizard-select>
-    <wizard-select disabled="" helper="Default value" label="Val" nullable="">
+    <wizard-select
+      disabled=""
+      helper="Default value"
+      label="Val"
+      nullable=""
+    >
       <mwc-list-item
         aria-disabled="false"
         aria-selected="false"
@@ -643,7 +661,7 @@
     </wizard-textfield>
     <wizard-select
       fixedmenuposition=""
-      helper="Function contraint"
+      helper="Function constraint"
       label="fc"
       required=""
     >
@@ -866,14 +884,19 @@
   >
   </mwc-button>
 </mwc-dialog>
+
 ```
 
 ## `defines a createDaWizard to create a new DA element`
 
-#### `looks like the latest snapshot`
+####   `looks like the latest snapshot`
 
 ```html
-<mwc-dialog defaultaction="close" heading="Edit DA" open="">
+<mwc-dialog
+  defaultaction="close"
+  heading="Edit DA"
+  open=""
+>
   <div id="wizard-content">
     <wizard-textfield
       dialoginitialfocus=""
@@ -1215,7 +1238,11 @@
         EntryID
       </mwc-list-item>
     </wizard-select>
-    <wizard-select fixedmenuposition="" helper="Type" label="type">
+    <wizard-select
+      fixedmenuposition=""
+      helper="Type"
+      label="type"
+    >
       <mwc-list-item
         aria-disabled="false"
         class="Struct"
@@ -1427,7 +1454,12 @@
         false
       </mwc-list-item>
     </wizard-select>
-    <wizard-select disabled="" helper="Default value" label="Val" nullable="">
+    <wizard-select
+      disabled=""
+      helper="Default value"
+      label="Val"
+      nullable=""
+    >
     </wizard-select>
     <wizard-textfield
       disabled=""
@@ -1438,7 +1470,7 @@
     </wizard-textfield>
     <wizard-select
       fixedmenuposition=""
-      helper="Function contraint"
+      helper="Function constraint"
       label="fc"
       required=""
     >
@@ -1658,4 +1690,6 @@
   >
   </mwc-button>
 </mwc-dialog>
+
 ```
+
diff --git a/src/translations/de.ts b/src/translations/de.ts
@@ -44,6 +44,7 @@ export const de: Translations = {
     showieds: 'Zeige IEDs im Substation-Editor',
   },
   menu: {
+    new: 'Neues projekt',
     title: 'Menü',
     viewLog: 'Protokoll anzeigen',
     viewDiag: 'Daignose anzeigen',

diff --git a/src/translations/en.ts b/src/translations/en.ts
@@ -19,13 +19,13 @@ export const en = {
     sAddr: 'Short address',
     valKind: 'Value kind',
     valImport: 'Import value',
-    fc: 'Function contraint',
+    fc: 'Function constraint',
     LNodeType: 'Logical Node Type',
-    lnClass: 'Logical node class',
+    lnClass: 'Logical Node Class',
     accessControl: 'Access control',
     transient: 'Transient data',
     Val: 'Default value',
-    dchg: 'Triggre on data change',
+    dchg: 'Trigger on data change',
     qchg: 'Trigger on quality change',
     dupd: 'Trigger on data update',
     fixedOffs: 'Fixed offset',
@@ -42,6 +42,7 @@ export const en = {
     showieds: 'Show IEDs in substation editor',
   },
   menu: {
+    new: 'New project',
     title: 'Menu',
     viewLog: 'View log',
     viewDiag: 'View diagnostics',
@@ -283,7 +284,7 @@ export const en = {
     wizard: {
       primary: 'Guess content',
       title: 'Select control model (ctlModel)',
-      description: `IEDs often contain more controlable logical nodes than switch gear in the field. \n You can select the control model(s) used specific for switch gear.`,
+      description: `IEDs often contain more controllable logical nodes than switchgear in the field. \n You can select the control model(s) used specific for switchgear.`,
     },
   },
   merge: {

diff --git a/src/wizards/controlwithiedname.ts b/src/wizards/controlwithiedname.ts
@@ -173,7 +173,7 @@ export function selectExtRefsWizard(
       title: cbId + ' - ' + iedName,
       primary: {
         icon: 'delete',
-        label: get('disconnect'), // FIXME: translate
+        label: get('disconnect'),
         action: disconnect(sinkExtRefs),
       },
       secondary: {

diff --git a/test/integration/editors/templates/lnodetype-wizard.test.ts b/test/integration/editors/templates/lnodetype-wizard.test.ts
@@ -315,7 +315,7 @@ describe('LNodeType wizards', () => {
           )
         ).to.not.exist;
       });
-      it('adds new lnodetype with corrrect id and lnClass', async () => {
+      it('adds new LNodeType with correct id and lnClass', async () => {
         beh.value = ensId;
         enaOpn.value = spsId;
         enaCls.value = spsId;
@@ -331,7 +331,7 @@ describe('LNodeType wizards', () => {
           )
         ).to.exist;
       });
-      it('adds selected DOs to new lnodetype', async () => {
+      it('adds selected DOs to new LNodeType', async () => {
         beh.value = ensId;
         enaOpn.value = spsId;
         enaCls.value = spsId;