-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Soundata: Reproducible use of audio datasets #6634
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
|
Review checklist for @hadwareConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hey everyone. Amazing work you did on that library, a real pleasure to be able to review it. I might actually also be using it in the near future :) @faroit I'm not sure about the authoring: while most authors have strong contributions to the codebase, some (like Guillem Cortès or Xavier Serra) don't have that many in comparison to others. Is that an issue for JOSS? Furthermore, Rachel Bittner from Pysox has made a lot of work on that library, should she be cited as well? |
Hi @hadware! Thanks for reviewing this 🙏 As @faroit said I'm currently on leave so I won't be able to follow the reviewing process as much, but maybe I can quickly clarify this: senior authors such as Xavier Serra and Juan Bello helped in the conceptualization of the libraries (e.g. deciding directions/datasets to focus on) as well as funding the team. @rabitt was initially in the authors list as we jointly created mirdata (the music cousin of soundata), but due to issues with her employer she had to remove herself, and she knows and is onboard with us continuing the project without her. @faroit can clarify further if this presents any issues with JOSS policies. |
All right, this clarifies it for me, i'll just tick the box for now and if @faroit thinks it isn't fair, we'll revert that. |
Review checklist for @hagenwConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I would propose to include Rachel Bittner to the list of authors, see soundata/soundata#163 |
The installation instructions are not completely working at the moment, see soundata/soundata#153. |
@hagenw thanks for bringing this up again but I think we have to accepts Magdalenas comment here #6634 (comment) |
Thanks, I overlooked that. I closed the corresponding issue. |
I have finished the review. It's a very nice contribution to the audio community. Here is a list of the issues, I would like to be tackled before accepting all points in the bullet list:
In addition, I would highly recommend to work on the following issues: |
All issues I have listed as required are now addressed, and I have marked all points as full filled in the review. |
@hadware can you also post some updates on your status, please? |
Everything seems good to me as well. I'd have liked that issue soundata/soundata#159 and soundata/soundata#160 to be addressed, but I understand it might be too much work to do in a short amount of time (and may also be out of the scope of this review). What do you think, @hagenw ? Otherwise, i'm good, cheers to soundata's authors for their good handling of all of our comments :) |
I would also highly recommend to work on those issues, but as I understand https://joss.readthedocs.io/en/latest/reviewer_guidelines.html, especially
I think, the current status matches already those best practices. |
Hello @hadware , @hagenw , |
Hello @faroit, We've merged soundata/soundata#169, which fixed a couple of issues raised by @hadware and @hagenw. As I understand it, we have complied with the checklists but we don't know what the next steps are. So please let us know if you need anything else from our side to move forward with the review. |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5508, then you can now move forward with accepting the submission by compiling again with the command |
There's one more small needed change I found: soundata/soundata#180 |
Seen. will merge now. One more thing, I was actually thinking now about the following paragraph:
I would change "researchers" to "users" (to match the rest of the article) and also maybe substituting the second one by "them". What do you think? It will look like this:
|
That sounds fine. |
Merged, can you regenerate the final proof pdf again, please? Thanks! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5509, then you can now move forward with accepting the submission by compiling again with the command |
@guillemcortes - Does this seem ok to go ahead with now? Please confirm |
Hi @danielskatz , it looks good to me. I've just pinged the rest of the authors to see if they want to do a final check. Can I come back to you tomorrow or so? |
sure, that's fine |
Hi @danielskatz , I just discussed it with my colleagues and we agree to move forward. Thank you very much for your review. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @magdalenafuentes ([Magdalena Fuentes]), @guillemcortes, and co-authors on your publication!! And thanks to @hagenw and @hadware for reviewing, and to @faroit for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
👋 @genisplaja @guillemcortes @magdalenafuentes @hagenw @hadware I just wanted to add here that I'm super happy how this submission came out. We not just had a rather quick turnaround time but also the submission substantially improved with the help of the very detailed and timely reviews as well as how they were addressed. After all, the communication on all sides was very effective and as such, a very positive example on how JOSS is designed to be. If we would have a best-paper/best-reviewer award, I would suggest this submission for both! Thanks a lot, everyone! |
👋 everyone, Thank you for the kind words, @faroit. I second @magdalenafuentes words. It has been a very enriching experience and we only have good words for all of you. Thanks again! |
Submitting author: @magdalenafuentes (Magdalena Fuentes)
Repository: https://github.com/soundata/soundata
Branch with paper.md (empty if default branch): paper
Version: v1.0.1
Editor: @faroit
Reviewers: @hagenw, @hadware
Archive: 10.5281/zenodo.11580085
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@hagenw & @hadware, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @faroit know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @hadware
📝 Checklist for @hagenw
The text was updated successfully, but these errors were encountered: